Fix heracles 200 for spark - #2267
Merged
chrisknoll merged 2 commits intoMay 5, 2023
Merged
Conversation
…ite-MedStar/WebAPI into fix_heracles_200_for_spark
Contributor
Author
|
I tested the original #2257 WebAPI patch on our local instance, and it also dropped the terminal semicolon (so blended together queries 200 and 500). The attached query renders correctly in https://data.ohdsi.org/SqlDeveloper/ |
chrisknoll
approved these changes
May 5, 2023
Collaborator
|
Thank you. The regex replaces in SqlRender is something we need to be careful about. Thanks for finding the issue and providing a fix. |
konstjar
pushed a commit
that referenced
this pull request
May 5, 2023
Contributor
Author
|
@chrisknoll and @konstjar - I tested Full Analysis on DataBricks using this patch. The run completes without error, and all of the generated analyses behave as expected. Thanks! |
konstjar
pushed a commit
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chrisknoll , This is further fix for #2257
The root cause may to be a "greedy" regex operator in SqlRender for Spark; but this fix ensures that the final semicolon is not trapped behind a single-line comment.