Fix cdmresults drill-down reports - #2257
Merged
Merged
Conversation
…s concatenated with report OHDSI#500
chrisknoll
approved these changes
Apr 25, 2023
chrisknoll
reviewed
Apr 25, 2023
Comment on lines
-22
to
-27
| vo1.place_of_service_CONCEPT_ID | ||
| vo1.place_of_service_CONCEPT_ID; | ||
| --} | ||
| --{@CDM_version == '5'}?{ | ||
| vo1.visit_CONCEPT_ID | ||
| vo1.visit_CONCEPT_ID; | ||
| --} | ||
| ; No newline at end of file |
Collaborator
There was a problem hiding this comment.
Slightly odd fix here: to move the trailing ; from the end into each of the branches of the SqlRender if-then block...but I don't think it's a problem.
Contributor
Author
There was a problem hiding this comment.
@chrisknoll , this looked like the safest solution. Of the dozens of files that contains the --{, and --} syntax, this is the only one that has --} immediately before the closing semi-colon. I tried adding extra newlines, but the parser for Spark seems to do a greedy match for whitespace after --}, so no matter how many newlines I added, I always got --; (but only in the Spark translation)
anton-abushkevich
pushed a commit
that referenced
this pull request
May 4, 2023
konstjar
pushed a commit
that referenced
this pull request
Jun 25, 2026
Fixes #2248. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three files had minor typos breaking drill-down report components.
Also fixes issue #2248 in Heracles Full Reports where analysis # 200 is concatenated to the next one (# 500).