Fix incorrect create image view error message#334
Merged
Overv merged 1 commit intoOverv:mainfrom May 9, 2023
Merged
Conversation
The function "createImageView" has a somewhat incorrect error message, saying that it failed to create a texture image view. However, the function is also used by more than simply the texture image view creation process(e.g., the swapchain image view creation process, "createImageViews").
Owner
|
Good catch, thanks! |
Overv
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function "createImageView" has a somewhat incorrect error message, saying that it failed to create a texture image view. However, the function is also used by more than simply the texture image view creation process(e.g., the swapchain image view creation process, "createImageViews").
This patch is applied to all subject code files, and the English "06_Texture_mapping/01_Image_view_and_sampler.md" file has also been modified.
The French version of the markdown file remains unchanged due to my lack of knowledge about French, but probably should be changed in the near future to maintain consistency.