Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix incorrect create image view error message #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Overv merged 1 commit into from
May 9, 2023
Merged

Fix incorrect create image view error message #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix incorrect create image view error message 
The function "createImageView" has a somewhat incorrect error message,
saying that it failed to create a texture image view. However, the
function is also used by more than simply the texture image view
creation process(e.g., the swapchain image view creation process, "createImageViews").
  • Loading branch information
@merrittlj
merrittlj committed May 8, 2023
commit bc259cabab61078e0904d32ae6ae562afecb6c7f
2 changes: 1 addition & 1 deletion code/25_sampler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ class HelloTriangleApplication {

VkImageView imageView;
if (vkCreateImageView(device, &viewInfo, nullptr, &imageView) != VK_SUCCESS) {
throw std::runtime_error("failed to create texture image view!");
throw std::runtime_error("failed to create image view!");
}

return imageView;
Expand Down
2 changes: 1 addition & 1 deletion code/26_texture_mapping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ class HelloTriangleApplication {

VkImageView imageView;
if (vkCreateImageView(device, &viewInfo, nullptr, &imageView) != VK_SUCCESS) {
throw std::runtime_error("failed to create texture image view!");
throw std::runtime_error("failed to create image view!");
}

return imageView;
Expand Down
2 changes: 1 addition & 1 deletion code/27_depth_buffering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ class HelloTriangleApplication {

VkImageView imageView;
if (vkCreateImageView(device, &viewInfo, nullptr, &imageView) != VK_SUCCESS) {
throw std::runtime_error("failed to create texture image view!");
throw std::runtime_error("failed to create image view!");
}

return imageView;
Expand Down
2 changes: 1 addition & 1 deletion code/28_model_loading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ class HelloTriangleApplication {

VkImageView imageView;
if (vkCreateImageView(device, &viewInfo, nullptr, &imageView) != VK_SUCCESS) {
throw std::runtime_error("failed to create texture image view!");
throw std::runtime_error("failed to create image view!");
}

return imageView;
Expand Down
2 changes: 1 addition & 1 deletion code/29_mipmapping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ class HelloTriangleApplication {

VkImageView imageView;
if (vkCreateImageView(device, &viewInfo, nullptr, &imageView) != VK_SUCCESS) {
throw std::runtime_error("failed to create texture image view!");
throw std::runtime_error("failed to create image view!");
}

return imageView;
Expand Down
2 changes: 1 addition & 1 deletion code/30_multisampling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,7 +1024,7 @@ class HelloTriangleApplication {

VkImageView imageView;
if (vkCreateImageView(device, &viewInfo, nullptr, &imageView) != VK_SUCCESS) {
throw std::runtime_error("failed to create texture image view!");
throw std::runtime_error("failed to create image view!");
}

return imageView;
Expand Down
2 changes: 1 addition & 1 deletion en/06_Texture_mapping/01_Image_view_and_sampler.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ VkImageView createImageView(VkImage image, VkFormat format) {

VkImageView imageView;
if (vkCreateImageView(device, &viewInfo, nullptr, &imageView) != VK_SUCCESS) {
throw std::runtime_error("failed to create texture image view!");
throw std::runtime_error("failed to create image view!");
}

return imageView;
Expand Down