PickNikRobotics · mosfet80 · Jan 27, 2020 · Apr 2, 2020 · Jun 2, 2020 · Jun 11, 2020
diff --git a/.ci.prepare_codecov b/.ci.prepare_codecov
@@ -0,0 +1,21 @@
+#!/bin/bash
+pushd $BASEDIR
+
+BLUE='\033[0;34m'
+NOCOLOR='\033[0m'
+
+apt-get install -qq lcov
+
+echo -e "${BLUE}Capture coverage info${NOCOLOR}"
+lcov --capture --directory target_ws --output-file coverage.info
+
+echo -e "${BLUE}Extract repository files${NOCOLOR}"
+lcov --extract coverage.info "$BASEDIR/target_ws/src/$TARGET_REPO_NAME/*" --output-file coverage.info
+
+echo -e "${BLUE}Filter out test files${NOCOLOR}"
+lcov --remove coverage.info '*/test/*' --output-file coverage.info
+
+echo -e "${BLUE}Output coverage data for debugging${NOCOLOR}"
+lcov --list coverage.info
+
+popd
diff --git a/.clang-format b/.clang-format
@@ -1,66 +1,75 @@
 ---
 BasedOnStyle:  Google
+ColumnLimit:    120
+MaxEmptyLinesToKeep: 1
+SortIncludes: false
+
+Standard:        Auto
+IndentWidth:     2
+TabWidth:        2
+UseTab:          Never
 AccessModifierOffset: -2
 ConstructorInitializerIndentWidth: 2
+NamespaceIndentation: None
+ContinuationIndentWidth: 4
+IndentCaseLabels: true
+IndentFunctionDeclarationAfterType: false
+
 AlignEscapedNewlinesLeft: false
 AlignTrailingComments: true
+
 AllowAllParametersOfDeclarationOnNextLine: false
+ExperimentalAutoDetectBinPacking: false
+ObjCSpaceBeforeProtocolList: true
+Cpp11BracedListStyle: false
+
+AllowShortBlocksOnASingleLine: true
 AllowShortIfStatementsOnASingleLine: false
 AllowShortLoopsOnASingleLine: false
 AllowShortFunctionsOnASingleLine: None
-AllowShortLoopsOnASingleLine: false
+AllowShortCaseLabelsOnASingleLine: false
+
 AlwaysBreakTemplateDeclarations: true
 AlwaysBreakBeforeMultilineStrings: false
 BreakBeforeBinaryOperators: false
 BreakBeforeTernaryOperators: false
 BreakConstructorInitializersBeforeComma: true
+
 BinPackParameters: true
-ColumnLimit:    120
 ConstructorInitializerAllOnOneLineOrOnePerLine: true
 DerivePointerBinding: false
 PointerBindsToType: true
-ExperimentalAutoDetectBinPacking: false
-IndentCaseLabels: true
-MaxEmptyLinesToKeep: 1
-NamespaceIndentation: None
-ObjCSpaceBeforeProtocolList: true
-PenaltyBreakBeforeFirstCallParameter: 19
-PenaltyBreakComment: 60
+
+PenaltyExcessCharacter: 50
+PenaltyBreakBeforeFirstCallParameter: 30
+PenaltyBreakComment: 1000
+PenaltyBreakFirstLessLess: 10
 PenaltyBreakString: 100
-PenaltyBreakFirstLessLess: 1000
-PenaltyExcessCharacter: 1000
-PenaltyReturnTypeOnItsOwnLine: 70
+PenaltyReturnTypeOnItsOwnLine: 50
+
 SpacesBeforeTrailingComments: 2
-Cpp11BracedListStyle: false
-Standard:        Auto
-IndentWidth:     2
-TabWidth:        2
-UseTab:          Never
-IndentFunctionDeclarationAfterType: false
 SpacesInParentheses: false
 SpacesInAngles:  false
 SpaceInEmptyParentheses: false
 SpacesInCStyleCastParentheses: false
+SpaceAfterCStyleCast: false
 SpaceAfterControlStatementKeyword: true
 SpaceBeforeAssignmentOperators: true
-ContinuationIndentWidth: 4
-SortIncludes: false
-SpaceAfterCStyleCast: false
 
 # Configure each individual brace in BraceWrapping
 BreakBeforeBraces: Custom
 
 # Control of individual brace wrapping cases
-BraceWrapping: {
-    AfterClass: 'true'
-    AfterControlStatement: 'true'
-    AfterEnum : 'true'
-    AfterFunction : 'true'
-    AfterNamespace : 'true'
-    AfterStruct : 'true'
-    AfterUnion : 'true'
-    BeforeCatch : 'true'
-    BeforeElse : 'true'
-    IndentBraces : 'false'
-}
+BraceWrapping:
+    AfterCaseLabel: true
+    AfterClass: true
+    AfterControlStatement: true
+    AfterEnum: true
+    AfterFunction: true
+    AfterNamespace: true
+    AfterStruct: true
+    AfterUnion: true
+    BeforeCatch: true
+    BeforeElse: true
+    IndentBraces: false
 ...
diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml
@@ -0,0 +1,81 @@
+# This config uses industrial_ci (https://github.com/ros-industrial/industrial_ci.git).
+# For troubleshooting, see readme (https://github.com/ros-industrial/industrial_ci/blob/master/README.rst)
+
+name: Build And Test
+
+on:
+  workflow_dispatch:
+  pull_request:
+  push:
+    branches:
+      - master
+
+jobs:
+  industrial_ci:
+    strategy:
+      matrix:
+        env:
+          - ROS_DISTRO: melodic
+            ROS_REPO: main
+          - ROS_DISTRO: melodic
+            ROS_REPO: testing
+          - ROS_DISTRO: noetic
+            ROS_REPO: main
+            CCOV: true
+            CLANG_TIDY: true
+          - ROS_DISTRO: noetic
+            ROS_REPO: testing
+
+    env:
+      AFTER_RUN_TARGET_TEST: ${{ matrix.env.CCOV && './.ci.prepare_codecov' || '' }}
+      TARGET_CMAKE_ARGS: >
+        -DCMAKE_BUILD_TYPE=${{ matrix.env.CCOV && 'Debug' || 'Release'}}
+        ${{ matrix.env.CCOV && '-DCMAKE_CXX_FLAGS="--coverage" --no-warn-unused-cli' || '' }}
+      CCACHE_DIR: ${{ github.workspace }}/.ccache
+      BASEDIR: ${{ github.workspace }}/.work
+      CACHE_PREFIX: ${{ matrix.env.ROS_DISTRO }}-${{ matrix.env.ROS_REPO }}${{ matrix.env.CCOV && '-ccov' || '' }}
+      CLANG_TIDY_BASE_REF: ${{ github.base_ref || github.ref }}
+
+    name: "${{ matrix.env.ROS_DISTRO }}-${{ matrix.env.ROS_REPO }}${{ matrix.env.CCOV && ' + ccov' || ''}}${{ matrix.env.CLANG_TIDY && ' + clang-tidy' || '' }}"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      # The target directory cache doesn't include the source directory because
+      # that comes from the checkout.  See "prepare target_ws for cache" task below
+      - name: cache target_ws
+        if: ${{ ! matrix.env.CCOV }}
+        uses: pat-s/[email protected]
+        with:
+          path: ${{ env.BASEDIR }}/target_ws
+          key: target_ws-${{ env.CACHE_PREFIX }}-${{ hashFiles('**/CMakeLists.txt', '**/package.xml') }}-${{ github.run_id }}
+          restore-keys: |
+            target_ws-${{ env.CACHE_PREFIX }}-${{ hashFiles('**/CMakeLists.txt', '**/package.xml') }}
+      - name: cache ccache
+        uses: pat-s/always-upload-cache@v3
+        with:
+          path: ${{ env.CCACHE_DIR }}
+          key: ccache-${{ env.CACHE_PREFIX }}-${{ github.sha }}-${{ github.run_id }}
+          restore-keys: |
+            ccache-${{ env.CACHE_PREFIX }}-${{ github.sha }}
+            ccache-${{ env.CACHE_PREFIX }}
+      - name: industrial_ci
+        uses: 'ros-industrial/industrial_ci@master'
+        env: ${{ matrix.env }}
+      - name: upload test artifacts (on failure)
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: test-results
+          path: ${{ env.BASEDIR }}/target_ws/**/test_results/**/*.xml
+      - name: upload codecov report
+        uses: codecov/codecov-action@v3
+        if: ${{ matrix.env.CCOV }}
+        with:
+          files: ${{ env.BASEDIR }}/coverage.info
+      - name: prepare target_ws for cache
+        if: ${{ always() && ! matrix.env.CCOV }}
+        run: |
+          du -sh ${{ env.BASEDIR }}/target_ws
+          sudo find ${{ env.BASEDIR }}/target_ws -wholename '*/test_results/*' -delete
+          sudo rm -rf ${{ env.BASEDIR }}/target_ws/src
+          du -sh ${{ env.BASEDIR }}/target_ws
diff --git a/.github/workflows/format.yaml b/.github/workflows/format.yaml
@@ -0,0 +1,20 @@
+# This is a format job. Pre-commit has a first-party GitHub action, so we use
+# that: https://github.com/pre-commit/action
+
+name: Format
+
+on:
+  workflow_dispatch:
+  pull_request:
+  push:
+
+jobs:
+  pre-commit:
+    name: Format
+    runs-on: ubuntu-20.04
+    steps:
+    - uses: actions/[email protected]
+    - uses: actions/setup-python@v5
+    - name: Install clang-format-10
+      run: sudo apt-get install clang-format-10
+    - uses: pre-commit/[email protected]
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -0,0 +1,49 @@
+# To use:
+#
+#     pre-commit run -a
+#
+# Or:
+#
+#     pre-commit install  # (runs every time you commit in git)
+#
+# To update this file:
+#
+#     pre-commit autoupdate
+#
+# See https://github.com/pre-commit/pre-commit
+
+repos:
+  # Standard hooks
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.4.0
+    hooks:
+      - id: check-added-large-files
+      - id: check-case-conflict
+      - id: check-json
+      - id: check-merge-conflict
+      - id: check-symlinks
+      - id: check-toml
+      - id: check-xml
+      - id: check-yaml
+      - id: debug-statements
+      - id: destroyed-symlinks
+      - id: detect-private-key
+      - id: end-of-file-fixer
+      - id: mixed-line-ending
+      - id: pretty-format-json
+      - id: trailing-whitespace
+
+  - repo: https://github.com/psf/black
+    rev: 23.3.0
+    hooks:
+      - id: black
+
+  - repo: local
+    hooks:
+      - id: clang-format
+        name: clang-format
+        description: Format files with ClangFormat.
+        entry: clang-format-10
+        language: system
+        files: \.(c|cc|cxx|cpp|frag|glsl|h|hpp|hxx|ih|ispc|ipp|java|js|m|proto|vert)$
+        args: ['-fallback-style=none', '-i']
diff --git a/.travis.yml b/.travis.yml
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -2,6 +2,54 @@
 Changelog for package rviz_visual_tools
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+3.9.3 (2023-01-05)
+------------------
+* Fix formatting CI job (`#230 <https://github.com/PickNikRobotics/rviz_visual_tools/issues/230>`_)
+* Move pub_rviz_markers\_ to it's own callback queue (`#193 <https://github.com/PickNikRobotics/rviz_visual_tools/issues/193>`_)
+* Contributors: Jochen Sprickerhof, Vatan Aksoy Tezer
+
+3.9.2 (2022-09-20)
+------------------
+* Cleanup for new Ubuntu versions (`#215 <https://github.com/PickNikRobotics/rviz_visual_tools/issues/215>`_)
+* spin independent thread for RemoteControl (`#224 <https://github.com/PickNikRobotics/rviz_visual_tools/issues/224>`_)
+  Avoid deadlocks and cross-thread effects with other callbacks.
+* Migrate CI to Github Actions (`#197 <https://github.com/PickNikRobotics/rviz_visual_tools/issues/197>`_)
+* migrate to <random> (`#195 <https://github.com/PickNikRobotics/rviz_visual_tools/issues/195>`_)
+* Fix bugtracker typo (`#186 <https://github.com/PickNikRobotics/rviz_visual_tools/issues/186>`_)
+* Contributors: Jochen Sprickerhof, Michael Görner, Nathan Brooks, Vatan Aksoy Tezer
+
+3.9.1 (2020-10-09)
+------------------
+* [maint] add soname versions to libraries (`#166 <https://github.com/tylerjw/rviz_visual_tools/issues/166>`_)
+* [maint] Apply clang-format-10 (`#173 <https://github.com/tylerjw/rviz_visual_tools/issues/173>`_)
+* Contributors: Tyler Weaver
+
+3.9.0 (2020-09-05)
+------------------
+* [feature] Add optional parent frame to iMarker (`#159 <https://github.com/tylerjw/rviz_visual_tools/issues/159>`_)
+* [feature] Publish cuboid with size as a vector3 or Eigen::Vector3d  (`#125 <https://github.com/tylerjw/rviz_visual_tools/issues/125>`_)
+* [feature] Normalize interactive marker quaternions. (`#132 <https://github.com/tylerjw/rviz_visual_tools/issues/132>`_)
+* [feature] normalize before publish (`#131 <https://github.com/tylerjw/rviz_visual_tools/issues/131>`_)
+* [feature] New helper function getIdentityPose() (`#122 <https://github.com/tylerjw/rviz_visual_tools/issues/122>`_)
+* [feature] Windows bring up. (`#116 <https://github.com/tylerjw/rviz_visual_tools/issues/116>`_)
+* [feature] For ABCD planes: better comments, ensure the plane equation is satisfied. (`#120 <https://github.com/tylerjw/rviz_visual_tools/issues/120>`_)
+* [feature] Make `rviz_visual_tools` publish triangle mesh and `tf_visual_tools` clean published transforms (`#117 <https://github.com/tylerjw/rviz_visual_tools/issues/117>`_)
+* [feature] Publish plane from Ax+By+Cz+D=0 equation (`#119 <https://github.com/tylerjw/rviz_visual_tools/issues/119>`_)
+* [feature] Remove default arguments to make function calls not ambiguous (`#112 <https://github.com/tylerjw/rviz_visual_tools/issues/112>`_)
+* [feature] Initizalize quaternions in demo to avoid warning (`#111 <https://github.com/tylerjw/rviz_visual_tools/issues/111>`_)
+* [fix] rviz warnings about scale and uninitialized quaternions (`#129 <https://github.com/tylerjw/rviz_visual_tools/issues/129>`_)
+* [fix] publishCylinder namespace (`#109 <https://github.com/tylerjw/rviz_visual_tools/issues/109>`_)
+* [fix] node type in demo launch files (`#110 <https://github.com/tylerjw/rviz_visual_tools/issues/110>`_)
+* [maint] Adding missing dependency (interactive_markers) (`#168 <https://github.com/tylerjw/rviz_visual_tools/issues/168>`_)
+* [maint] clang-tidy (`#158 <https://github.com/tylerjw/rviz_visual_tools/issues/158>`_)
+* [maint] replace tf_conversions with tf2 (`#151 <https://github.com/tylerjw/rviz_visual_tools/issues/151>`_)
+* [maint] bump cmake version (`#150 <https://github.com/tylerjw/rviz_visual_tools/issues/150>`_)
+* [maint] remove trailing whitespaces (`#130 <https://github.com/tylerjw/rviz_visual_tools/issues/130>`_)
+* [maint] Apply clang-tidy (`#127 <https://github.com/tylerjw/rviz_visual_tools/issues/127>`_)
+* [maint] Switch to moveit_ci, apply clang-format (`#124 <https://github.com/tylerjw/rviz_visual_tools/issues/124>`_)
+* [maint] Use LOGNAME for logging re:moveit styel (`#106 <https://github.com/tylerjw/rviz_visual_tools/issues/106>`_)
+* Contributors: AndyZe, Bjar Ne, Dave Coleman, Jafar Abdi, JafarAbdi, Michael Görner, Mike Lautman, Sean Yen, Victor Lamoine, Yu, Yan, d-walsh
+
 3.7.0 (2018-11-26)
 ------------------
 * Fix Eigen::Affine3d for Melodic (using Eigen::Isometry3d) (`#105 <https://github.com/PickNikRobotics/rviz_visual_tools/issues/105>`_)