Update .pre-commit-config.yaml #269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of CMP0048 warning. moveit/geometric_shapes#129
Co-authored-by: Bjar Ne <[email protected]>
* Add optional parent frame to iMarker * Use getIdentityPose() * Clang format * Clang tidy
Avoid deadlocks and cross-thread effects with other callbacks.
waitForSubscriber used to call ros::spinOnce() which could trigger callbacks from other topics in other threads. In case those have a lock to only get called once, this would look the visual_tools thread. Closes: PickNikRobotics#146
update pre-commit libraries
updated pat-s/always-upload-cache@v3
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ros2 #269 +/- ##
==========================================
- Coverage 19.86% 13.28% -6.58%
==========================================
Files 5 12 +7
Lines 1858 2303 +445
Branches 0 131 +131
==========================================
- Hits 369 306 -63
- Misses 1489 1987 +498
- Partials 0 10 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/psf/black/releases/tag/24.10.0