GTMetrix - New Test Completed filter by source #18382

michelle0927 · 2025-09-16T20:29:58Z

Resolves #14909

Summary by CodeRabbit

New Features
- GTmetrix “New Test Completed” source now lets you choose which test sources to emit events for (API, On‑Demand, Monitored). Supports multiple selections to filter notifications and reduce noise.
Chores
- Updated package version to 0.1.1.
- Refreshed underlying dependencies for improved compatibility.

vercel · 2025-09-16T20:30:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
pipedream-docs	Ignored			Sep 16, 2025 8:30pm
pipedream-docs-redirect-do-not-edit	Ignored			Sep 16, 2025 8:30pm

coderabbitai · 2025-09-16T20:30:07Z

Walkthrough

Version bumps in GTMetrix component and dependency. The “New Test Completed” source adds a new testSources prop and includes a filter[source] parameter in API requests. No other public APIs changed.

Changes

Cohort / File(s)	Summary of changes
Package version and dependency bump `components/gtmetrix/package.json`	Version 0.1.0 → 0.1.1. Updated dependency `@pipedream/platform` from `^1.5.1` to `^3.1.0`.
GTMetrix New Test Completed source update `components/gtmetrix/sources/new-test-completed/new-test-completed.mjs`	Source version 0.0.1 → 0.0.2. Added public prop `testSources: string[]` with options `["api","on-demand","monitored"]` and default `["api"]`. Extended `getArgs(lastTs)` to add request param `filter[source]` from `this.testSources.join(", ")`.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant T as Timer/Cron
  participant S as GTMetrix Source (New Test Completed)
  participant A as GTMetrix API
  participant E as Event Stream

  T->>S: Trigger poll
  rect rgba(200,235,255,0.3)
    note right of S: Build request params<br/>• lastTs<br/>• filter[source]=join(testSources)
    S->>A: GET /tests?lastTs=...&filter[source]=api,on-demand,...
  end
  A-->>S: 200 OK + tests
  alt New completed tests
    S->>E: Emit events for returned tests
  else No new tests
    S-->>T: No-op
  end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit taps the API with glee,
Filtering sources: api, on-demand, three!
New tests hop in, events now chime,
Version bumps set the rhythm and time.
With whiskers twitching, I emit and cheer—
“GTMetrix heard, your alerts are here!” 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Out of Scope Changes Check	⚠️ Warning	The PR includes a dependency bump in components/gtmetrix/package.json (updating @pipedream/platform from ^1.5.1 to ^3.1.0) and a package version bump, which are not required to add the source filter and therefore appear out of scope for resolving the linked issue. Such dependency and version changes can introduce unrelated behavior or compatibility risks and make it harder to review the functional change in isolation. They should be justified or isolated to avoid conflating concerns.	Either move the dependency and package version bumps to a separate PR or provide a clear justification and compatibility test results in this PR; run full CI and integration tests to demonstrate the platform upgrade does not affect runtime behavior and document why the bump is necessary for the GTMetrix fix. If the bump must remain, add notes in the PR explaining the dependency change and the verification performed.
Description Check	⚠️ Warning	The PR description contains only "Resolves #14909" and does not follow the repository's required template, which expects a "WHY" section describing motivation, scope, and context; it therefore lacks the rationale, testing notes, and configuration details needed for reviewers. Without a filled "WHY" section the change's intent and verification steps are unclear to reviewers. This makes the description insufficient for a proper review.	Update the PR description to include the required "WHY" section: explain the motivation, summarize the code changes, state how the change resolves #14909, and provide reproduction steps and test evidence (logs or screenshots) plus any configuration defaults (e.g., the default testSources value). After updating, attach or reference CI/integration test results to help reviewers verify the fix.
Linked Issues Check	❓ Inconclusive	The changes (adding a testSources prop and including "filter[source]" in the API query) directly target the linked issue's symptom by providing a way to filter which GTMetrix test sources are queried and thus are aligned with the objective in [#14909]. However, the PR leaves the default set to ["api"], provides no runtime logs or tests proving that previously-missed alerts (on-demand or monitored) are now emitted, and does not clarify whether the API expects the exact parameter formatting used, so the actual resolution of the non-emission problem cannot be confirmed from the diff alone. Given the lack of verification and clarity about defaults/parameter format, the compliance with the linked issue is inconclusive.	Add integration test output or runtime logs demonstrating that alerts now appear for the relevant GTMetrix sources, document the mapping between the prop options and the API's accepted source values, and justify or change the default testSources if needed (for example to include monitored/on-demand) so reviewers can confirm the issue is resolved. Also include a short note in the PR description describing the verification steps taken.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "GTMetrix - New Test Completed filter by source" clearly and concisely summarizes the primary change — adding a source filter to the GTMetrix "New Test Completed" source — and matches the code changes that add a testSources prop and a filter[source] request parameter. It is specific, focused, and understandable to a reviewer scanning history. The title accurately reflects the main intent of the changes.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch issue-14909

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3e3821 and cba49a8.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

components/gtmetrix/package.json (2 hunks)
components/gtmetrix/sources/new-test-completed/new-test-completed.mjs (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2024-12-12T19:23:09.039Z

Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.

Applied to files:

components/gtmetrix/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: pnpm publish
GitHub Check: Verify TypeScript components
GitHub Check: Publish TypeScript components
GitHub Check: Lint Code Base

🔇 Additional comments (4)

components/gtmetrix/package.json (2)

3-3: Version bump looks good.

Patch release is appropriate for this change.

16-16: Platform upgrade: verify compatibility.

Bumping to @pipedream/platform ^3.1.0 is fine, but please confirm no behavior changes for multi-select props (string[]) in sources using this package.

components/gtmetrix/sources/new-test-completed/new-test-completed.mjs (2)

8-8: Source version bump LGTM.

11-26: Prop shape looks correct; consider default semantics.

Defaulting testSources to ["api"] preserves BC, but it may not address Issue #14909 unless users opt in to "monitored"/"on-demand". Consider defaulting to all three, or at least call this out in the description/help text.

Reference: GTmetrix defaults to source=api unless overridden; monitored/on-demand are valid sources. (gtmetrix.com)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

luancazarine

Hi @michelle0927, LGTM! Ready for QA!

* add testSources prop * pnpm-lock.yaml * fix

* Leonardo AI components * added unzoom image action * fixing link errors * more lint fixes * Merging pull request #18359 * fix: pagination prop and params struct * fix: no need for paginate here * chore: update version * chore: cleanup * chore: update package * feat: allow raw response * chore: bump package * fix: buffer response instead * Update components/google_drive/actions/download-file/download-file.mjs Co-authored-by: Jorge Cortes <[email protected]> * versions * pnpm-lock.yaml * pnpm-lock.yaml * pnpm-lock.yaml * feat: add content selector * chore: bump package * fix: comments * chore: bump versions * chore: fix versions * fixes: QA fixes * feat: add cursor to req * package.json --------- Co-authored-by: joao <[email protected]> Co-authored-by: joaocoform <[email protected]> Co-authored-by: Jorge Cortes <[email protected]> Co-authored-by: Michelle Bergeron <[email protected]> Co-authored-by: Luan Cazarine <[email protected]> * Merging pull request #18361 * update siteId prop * pnpm-lock.yaml * package.json version * Google Sheets - update row refresh fields (#18369) * change prop order and refresh fields * bump package.json * Pipedrive - fix app name (#18370) * use pipedriveApp instead of app * bump package.json * Pipedrive - pipelineId integer (#18372) * pipelineId - integer * bump versions * Adding app scaffolding for lightspeed_ecom_c_series * Adding app scaffolding for financial_data * Adding app scaffolding for microsoft_authenticator * Merging pull request #18345 * updates * versions * versions * Merging pull request #18368 * updates * remove console.log * versions * Coinbase Developer Platform - New Wallet Event (#18342) * new component * pnpm-lock.yaml * updates * updates * Hubspot - update search-crm (#18360) * update search-crm * limit results to one page * update version * package.json version * Merging pull request #18347 * widget props * fix version * Adding app scaffolding for rundeck * Merging pull request #18378 * Update Taiga component with new actions and sources - Bump version to 0.1.0 in package.json and add dependency on @pipedream/platform. - Introduce new actions for creating, updating, and deleting issues, tasks, and user stories. - Add sources for tracking changes and deletions of issues and tasks. - Implement utility functions for parsing and cleaning objects in common/utils.mjs. - Enhance prop definitions for better integration with Taiga API. * pnpm update * Refactor Taiga actions to utilize parseObject utility - Added parseObject utility for tags, watchers, and points in update-issue, update-task, and update-userstory actions. - Removed the update-project action as it is no longer needed. - Enhanced base source to include secret key validation for webhook security. * Merging pull request #18382 * add testSources prop * pnpm-lock.yaml * fix * Merging pull request #18323 * Added actions * Added actions * Added actions * Merging pull request #18377 * Added actions * Update components/weaviate/actions/create-class/create-class.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Luan Cazarine <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Merging pull request #18376 * Adding app scaffolding for etrusted * Adding app scaffolding for intelliflo_office * Adding app scaffolding for thoughtspot * Adding app scaffolding for kordiam * Adding app scaffolding for ticketsauce * trustpilot fixes (#18152) * trustpilot fixes * more fixes * update versions * more version updates * fixes * Bump all Trustpilot actions to version 0.1.0 Major improvements and API updates across all actions: - Enhanced private API support with proper authentication - Improved parameter handling and validation - Better error handling and response structures - Added new conversation flow for product reviews - Fixed endpoint URLs to match latest API documentation - Streamlined request/response processing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * up version and clean up sources * merge * fix business ID * delete temp action * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-service-reviews/new-service-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * comments * Pagination * fixes * comments * missed some `$`'s * unduplicated * more fixes * final comments * more comments * . --------- Co-authored-by: Claude <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Adding app scaffolding for peekalink * 18314 twilio (#18350) * Update Twilio component versions and dependencies - Update Twilio Send Message action adding detailed description for 'from' prop and refactoring phone number validation logic. - Incremented action versions for several Twilio actions. * pnpm update * Updating LinkedIn API version (#18399) * Merging pull request #18394 * Databricks API - Jobs action components (#18371) * Notion property building improvements (#18381) * validate property types * versions * Google Business - add debug log (#18407) * add debug log * bump versions * Notion API Key - update @pipedream/notion version (#18409) * update @pipedream/notion dependency version * pnpm-lock.yaml * Adding app scaffolding for reduct_video * Adding app scaffolding for shopware * Adding app scaffolding for instamojo * Hubspot - bug fix to sources w/ property changes (#18379) * updates * versions * Google sheets type fix (#18411) * Fixing worksheetId prop type from string to integer * Version bumps --------- Co-authored-by: Leo Vu <[email protected]> * Merging pull request #18393 * new components * remove console.log * versions * update * Merging pull request #18408 * 403 error message * versions * update * Merging pull request #18419 * Changes per PR Review * Removes leonardo_ai_actions.mdc not indented for merging * synced lockfile after install * fully lock form-data for leonardo_ai * conflict solving * lint fixes * Chipped down Readme, implemented async options in gen motion --------- Co-authored-by: jocarino <[email protected]> Co-authored-by: joao <[email protected]> Co-authored-by: joaocoform <[email protected]> Co-authored-by: Jorge Cortes <[email protected]> Co-authored-by: Michelle Bergeron <[email protected]> Co-authored-by: Luan Cazarine <[email protected]> Co-authored-by: michelle0927 <[email protected]> Co-authored-by: Andrew Chuang <[email protected]> Co-authored-by: danhsiung <[email protected]> Co-authored-by: Lucas Caresia <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Job <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Guilherme Falcão <[email protected]> Co-authored-by: Leo Vu <[email protected]>

michelle0927 added 3 commits September 16, 2025 16:26

add testSources prop

b83828a

pnpm-lock.yaml

1777ac4

fix

cba49a8

pipedream-component-development requested a review from luancazarine September 16, 2025 20:41

luancazarine approved these changes Sep 16, 2025

View reviewed changes

vunguyenhung merged commit 126fe3f into master Sep 17, 2025
10 checks passed

vunguyenhung deleted the issue-14909 branch September 17, 2025 03:15

sergio-eliot-rodriguez pushed a commit to sergio-eliot-rodriguez/sergio_wong_does_pipedream that referenced this pull request Sep 21, 2025

Merging pull request PipedreamHQ#18382

3cb8df5

* add testSources prop * pnpm-lock.yaml * fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GTMetrix - New Test Completed filter by source #18382

GTMetrix - New Test Completed filter by source #18382

Uh oh!

michelle0927 commented Sep 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Sep 16, 2025

Uh oh!

coderabbitai bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

luancazarine left a comment

Uh oh!

Uh oh!

Uh oh!

GTMetrix - New Test Completed filter by source #18382

GTMetrix - New Test Completed filter by source #18382

Uh oh!

Conversation

michelle0927 commented Sep 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Sep 16, 2025

Uh oh!

coderabbitai bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

luancazarine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michelle0927 commented Sep 16, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 16, 2025 •

edited

Loading