Google sheets type fix #18411
Google sheets type fix #18411
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughThis PR updates version metadata across multiple Google Sheets actions and sources. It also changes the worksheetIDs prop type from string to integer in the app and from string[] to integer[] in shared source modules. Package version is bumped. No runtime logic or control flow changes are introduced. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (9)
components/google_sheets/actions/update-multiple-rows/update-multiple-rows.mjs (1)
103-108: User-facing typo in error message“send a single rows” → “send a single row”.
- "Rows data is not an array of arrays. Please enter an array of arrays in the `Rows` parameter above. If you're trying to send a single rows to Google Sheets, search for the action to add a single row to Sheets or try modifying the code for this step.", + "Rows data is not an array of arrays. Please enter an array of arrays in the `Rows` parameter above. If you're trying to send a single row to Google Sheets, search for the action to add a single row to Sheets or try modifying the code for this step.",components/google_sheets/actions/update-row/update-row.mjs (1)
179-181: Grammar nit in validation error“A one-dimensional is expected.” → “A one-dimensional array is expected.”
- throw new ConfigurationError("Row Values is a multi-dimensional array. A one-dimensional is expected."); + throw new ConfigurationError("Row Values is a multi-dimensional array. A one-dimensional array is expected.");components/google_sheets/actions/add-column/add-column.mjs (1)
49-50: Use strict equality now that IDs are integersAvoid type coercion: prefer
===when comparings.properties.sheetIdtothis.worksheetId.- .filter((s) => s.properties.sheetId == this.worksheetId); + .filter((s) => s.properties.sheetId === this.worksheetId);components/google_sheets/actions/insert-anchored-note/insert-anchored-note.mjs (1)
33-37: Label/terminology consistency: Comment vs NoteThis action writes to the cell
notefield. Consider renaming label/description to “Note” for consistency.- content: { - type: "string", - label: "Comment", - description: "The comment to add to the spreadsheet.", - }, + content: { + type: "string", + label: "Note", + description: "The note to add to the spreadsheet cell.", + },components/google_sheets/actions/add-single-row/add-single-row.mjs (1)
13-13: Version bump OK; guardisDynamicExpressionfor non-strings.
worksheetIdis now numeric; callingisDynamicExpression(worksheetId)should be type-safe. Add a simple type check to avoid surprises.Apply:
- if (isDynamicExpression(sheetId) || isDynamicExpression(worksheetId)) { + if (isDynamicExpression(sheetId) || (typeof worksheetId === "string" && isDynamicExpression(worksheetId))) {and in
run():- if (this.hasHeaders - && !isDynamicExpression(sheetId) - && !isDynamicExpression(worksheetId) + if (this.hasHeaders + && !isDynamicExpression(sheetId) + && !(typeof worksheetId === "string" && isDynamicExpression(worksheetId)) && this.allColumns ) {components/google_sheets/actions/find-row/find-row.mjs (1)
10-10: Version bump OK; prefer explicit cell extraction over==coercion.Minor:
values.getfor a single column returns rows like["val"]. Avoid loose==by unwrapping before compare.Apply:
- const result = colValues.reduce((values, value, index) => { - if (value == this.value) { + const result = colValues.reduce((values, value, index) => { + const cell = Array.isArray(value) ? value[0] : value; + if (cell === this.value) { rows.push({ - value, + value: cell, index, googleSheetsRowNumber: index + 1, }); } return rows; }, []);components/google_sheets/sources/common/new-updates.mjs (2)
98-101: A1 notation bug: cell addresses should not contain a colon.
cell: \${this.indexToColumnLabel(j)}:${i + 1}`should beA1-style (A1), not a range (A:1`).Apply:
- cell: `${this.indexToColumnLabel(j)}:${i + 1}`, + cell: `${this.indexToColumnLabel(j)}${i + 1}`,
128-132: Potential column count bug when both rows exist.Fallback uses
oldValues.lengthinstead ofoldValues[i].length, which can under/over-count columns.Apply:
- newValues[i].length > oldValues[i].length - ? newValues[i].length - : oldValues.length; + newValues[i].length > oldValues[i].length + ? newValues[i].length + : oldValues[i].length;components/google_sheets/google_sheets.app.mjs (1)
338-345: Nit: JSDoc param type forworksheetIdsshould be an array.The implementation expects an array and uses
new Set(worksheetIds).Apply:
- * @param {string} worksheetIds - Ids of the worksheets within the spreadsheet + * @param {string[]} worksheetIds - Ids of the worksheets within the spreadsheet
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (30)
components/google_sheets/actions/add-column/add-column.mjs(1 hunks)components/google_sheets/actions/add-multiple-rows/add-multiple-rows.mjs(1 hunks)components/google_sheets/actions/add-single-row/add-single-row.mjs(1 hunks)components/google_sheets/actions/clear-cell/clear-cell.mjs(1 hunks)components/google_sheets/actions/clear-rows/clear-rows.mjs(1 hunks)components/google_sheets/actions/copy-worksheet/copy-worksheet.mjs(1 hunks)components/google_sheets/actions/create-spreadsheet/create-spreadsheet.mjs(1 hunks)components/google_sheets/actions/create-worksheet/create-worksheet.mjs(1 hunks)components/google_sheets/actions/delete-rows/delete-rows.mjs(1 hunks)components/google_sheets/actions/delete-worksheet/delete-worksheet.mjs(1 hunks)components/google_sheets/actions/find-row/find-row.mjs(1 hunks)components/google_sheets/actions/get-cell/get-cell.mjs(1 hunks)components/google_sheets/actions/get-spreadsheet-by-id/get-spreadsheet-by-id.mjs(1 hunks)components/google_sheets/actions/get-values-in-range/get-values-in-range.mjs(1 hunks)components/google_sheets/actions/insert-anchored-note/insert-anchored-note.mjs(1 hunks)components/google_sheets/actions/insert-comment/insert-comment.mjs(1 hunks)components/google_sheets/actions/list-worksheets/list-worksheets.mjs(1 hunks)components/google_sheets/actions/update-cell/update-cell.mjs(1 hunks)components/google_sheets/actions/update-multiple-rows/update-multiple-rows.mjs(1 hunks)components/google_sheets/actions/update-row/update-row.mjs(1 hunks)components/google_sheets/actions/upsert-row/upsert-row.mjs(1 hunks)components/google_sheets/google_sheets.app.mjs(1 hunks)components/google_sheets/package.json(1 hunks)components/google_sheets/sources/common/new-row-added.mjs(1 hunks)components/google_sheets/sources/common/new-updates.mjs(1 hunks)components/google_sheets/sources/new-comment/new-comment.mjs(1 hunks)components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs(1 hunks)components/google_sheets/sources/new-row-added/new-row-added.mjs(1 hunks)components/google_sheets/sources/new-updates/new-updates.mjs(1 hunks)components/google_sheets/sources/new-worksheet/new-worksheet.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (30)
components/google_sheets/actions/update-multiple-rows/update-multiple-rows.mjs (2)
12-12: Version bump only — OKNo functional changes in this file besides the version update.
34-43: Verified: integer worksheet IDs are supportedgetWorksheetById coerces both sides to String (String(sheetId) === String(worksheetId)); worksheetIDs is defined as integer upstream and consumers already normalize/compare IDs to strings where needed. No change required.
- components/google_sheets/actions/common/worksheet.mjs — getWorksheetById uses String(...) === String(...).
- components/google_sheets/google_sheets.app.mjs — propDefinitions.worksheetIDs is type: "integer" (options return numeric sheetId).
- components/google_sheets/sources/common/new-row-added.mjs, components/google_sheets/sources/common/new-updates.mjs — getWorksheetIds()/usage map IDs to strings and use string keys/lookups.
components/google_sheets/actions/update-row/update-row.mjs (2)
13-13: Version bump only — OKNo behavior change here.
35-57: Dynamic worksheet options — type safety check
worksheetIDsnow returns integers. The options loader forwardssheetIddirectly; confirm the underlying options function and any cache keys treat IDs as numbers to avoid mismatched cache hits.components/google_sheets/package.json (1)
3-3: Package version bump — OKVersion aligns with action/source bumps.
components/google_sheets/actions/add-column/add-column.mjs (1)
7-7: Version bump only — OKcomponents/google_sheets/actions/delete-rows/delete-rows.mjs (2)
7-7: Version bump only — OK
56-62: No change required:endIndex - 1is needed to convert the 1-based exclusive row number into the API’s 0-based exclusive index. (developers.google.com)Likely an incorrect or invalid review comment.
components/google_sheets/actions/get-spreadsheet-by-id/get-spreadsheet-by-id.mjs (1)
7-7: Version bump only — OKcomponents/google_sheets/actions/insert-anchored-note/insert-anchored-note.mjs (1)
8-8: Version bump only — OKcomponents/google_sheets/actions/create-worksheet/create-worksheet.mjs (1)
7-7: Version bump only — OKcomponents/google_sheets/sources/new-row-added/new-row-added.mjs (1)
11-11: Version bump aligns with the type fix changes.The version increment from 0.1.16 to 0.1.17 is appropriate as it reflects the underlying type corrections for worksheet ID properties across the Google Sheets package.
components/google_sheets/actions/clear-rows/clear-rows.mjs (1)
10-10: Version bump correctly reflects the package-wide type fixes.The version increment from 0.1.12 to 0.1.13 is consistent with the PR's worksheet ID type corrections.
components/google_sheets/actions/copy-worksheet/copy-worksheet.mjs (1)
7-7: Version bump is appropriate for the type fix changes.The version increment from 0.1.10 to 0.1.11 correctly reflects the underlying worksheet ID type corrections in this PR.
components/google_sheets/actions/delete-worksheet/delete-worksheet.mjs (1)
7-7: Version bump is consistent with the type fix changes.The version increment from 0.1.10 to 0.1.11 appropriately reflects the worksheet ID type corrections being applied across the Google Sheets package.
components/google_sheets/actions/create-spreadsheet/create-spreadsheet.mjs (1)
7-7: Version bump correctly reflects the package-wide changes.The version increment from 0.1.12 to 0.1.13 is appropriate for the worksheet ID type corrections being applied in this PR.
components/google_sheets/actions/insert-comment/insert-comment.mjs (1)
7-7: Version bump is appropriate for the type fix changes.The version increment from 0.1.11 to 0.1.12 correctly reflects the worksheet ID type corrections being applied across the Google Sheets package.
components/google_sheets/sources/new-worksheet/new-worksheet.mjs (1)
12-12: Version bump aligns with the package-wide type corrections.The version increment from 0.1.14 to 0.1.15 is consistent with the worksheet ID type fixes being applied across the Google Sheets components.
components/google_sheets/actions/add-multiple-rows/add-multiple-rows.mjs (1)
14-14: Version bump is appropriate for the type fix changes.The version increment from 0.2.13 to 0.2.14 correctly reflects the worksheet ID type corrections being applied in this PR.
components/google_sheets/actions/list-worksheets/list-worksheets.mjs (1)
7-7: Metadata-only change acknowledged.Nothing else changed; safe to merge.
components/google_sheets/sources/new-comment/new-comment.mjs (1)
9-9: Version bump only.No functional impact; source behavior unchanged.
components/google_sheets/actions/clear-cell/clear-cell.mjs (1)
10-10: Version bump OK; worksheetId type alignment check.Action still relies on
worksheetIDsprop. Please confirm integers now flow through UI/options andgetWorksheetByIdwithout coercion issues.Use the same script shared on get-cell to confirm definitions/usages.
components/google_sheets/actions/upsert-row/upsert-row.mjs (1)
27-27: Version bump only.Upsert flow unchanged; no issues spotted.
components/google_sheets/actions/get-cell/get-cell.mjs (1)
10-10: Version bump OK — worksheetId integer plumbing verified.getWorksheetById casts both sides to String for comparison, so it accepts numeric or string IDs (components/google_sheets/actions/common/worksheet.mjs). worksheetIDs.options returns properties.sheetId (numeric) (components/google_sheets/google_sheets.app.mjs) and sources convert worksheetIDs to strings via getWorksheetIds() (components/google_sheets/sources/common/new-updates.mjs). No changes required.
components/google_sheets/actions/update-cell/update-cell.mjs (1)
10-10: Version bump only — OK.No functional changes; safe to merge.
components/google_sheets/sources/common/new-row-added.mjs (1)
19-22: Prop type switched to integer[] — alignments look good; verify legacy configs.The UI/backend note suggests some older workflows may still have string IDs saved. Your
getWorksheetIds()usestoString(), so runtime is tolerant. Please sanity-check that existing sources with string IDs pass validation after this type change.components/google_sheets/sources/common/new-updates.mjs (1)
19-22: Prop type integer[] — consistent with app options.Matches numeric
sheetIdvalues from options; runtime conversions to string are preserved. Consider validating/coercing mixed inputs if the UI still emits strings for some users.components/google_sheets/sources/new-updates/new-updates.mjs (1)
12-12: Version bump only — OK.components/google_sheets/actions/get-values-in-range/get-values-in-range.mjs (1)
10-10: Version bump only — OK.components/google_sheets/google_sheets.app.mjs (1)
74-94: PropDefinition type → integer — correct for numeric sheetId values; confirm migration.Options return numbers, so this aligns types. Please verify existing actions/sources with string worksheet IDs still validate in the UI after this change.
| name: "New Row Added", | ||
| description: "Emit new event each time a row or rows are added to the bottom of a spreadsheet.", | ||
| version: "0.0.8", | ||
| version: "0.0.9", |
There was a problem hiding this comment.
🧩 Analysis chain
Version bump only.
Since this spreads ...common, ensure common.new-row-added’s worksheetIDs prop changed to integer[] and downstream logic treats them as numbers.
🏁 Script executed:
#!/bin/bash
rg -n -C3 'new-row-added\.mjs'
rg -n -C2 'worksheetIDs' components/google_sheets/sources/commonLength of output: 4239
Version bump only — worksheetIDs must be numeric and handled as numbers.
- common.new-row-added still converts worksheetIDs to strings; change the prop to integer[] (if not already) and stop coercing to strings (remove or replace
.map(i => i.toString())) so downstream logic compares numbers. - Fix locations: components/google_sheets/sources/common/new-row-added.mjs (props at ~line 11; getWorksheetIds() at ~line 114), components/google_sheets/sources/common/new-updates.mjs (props at ~line 11; getWorksheetIds() at ~line 57; usage around ~lines 166–183), and verify consumers such as components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs that import
...common.
🤖 Prompt for AI Agents
In components/google_sheets/sources/common/new-row-added.mjs (props around line
11; getWorksheetIds around line 114),
components/google_sheets/sources/common/new-updates.mjs (props around line 11;
getWorksheetIds around line 57; usages ~166–183), and consumers like
components/google_sheets/sources/new-row-added-polling/new-row-added-polling.mjs,
change the worksheetIDs prop type to integer[] (or equivalent runtime validation
to ensure numbers), remove any .map(i => i.toString()) coercions, update
getWorksheetIds() implementations to parse/return numbers (e.g., Number(...) or
parseInt) and ensure all downstream comparisons treat IDs as numbers, and update
any usage sites to compare numerically rather than against string IDs so the
entire flow consistently handles worksheet IDs as numbers.
|
Hi everyone, all test cases are passed! Ready for release! Test report |
|
/approve |
* Fixing worksheetId prop type from string to integer * Version bumps --------- Co-authored-by: Leo Vu <[email protected]>
* Leonardo AI components * added unzoom image action * fixing link errors * more lint fixes * Merging pull request #18359 * fix: pagination prop and params struct * fix: no need for paginate here * chore: update version * chore: cleanup * chore: update package * feat: allow raw response * chore: bump package * fix: buffer response instead * Update components/google_drive/actions/download-file/download-file.mjs Co-authored-by: Jorge Cortes <[email protected]> * versions * pnpm-lock.yaml * pnpm-lock.yaml * pnpm-lock.yaml * feat: add content selector * chore: bump package * fix: comments * chore: bump versions * chore: fix versions * fixes: QA fixes * feat: add cursor to req * package.json --------- Co-authored-by: joao <[email protected]> Co-authored-by: joaocoform <[email protected]> Co-authored-by: Jorge Cortes <[email protected]> Co-authored-by: Michelle Bergeron <[email protected]> Co-authored-by: Luan Cazarine <[email protected]> * Merging pull request #18361 * update siteId prop * pnpm-lock.yaml * package.json version * Google Sheets - update row refresh fields (#18369) * change prop order and refresh fields * bump package.json * Pipedrive - fix app name (#18370) * use pipedriveApp instead of app * bump package.json * Pipedrive - pipelineId integer (#18372) * pipelineId - integer * bump versions * Adding app scaffolding for lightspeed_ecom_c_series * Adding app scaffolding for financial_data * Adding app scaffolding for microsoft_authenticator * Merging pull request #18345 * updates * versions * versions * Merging pull request #18368 * updates * remove console.log * versions * Coinbase Developer Platform - New Wallet Event (#18342) * new component * pnpm-lock.yaml * updates * updates * Hubspot - update search-crm (#18360) * update search-crm * limit results to one page * update version * package.json version * Merging pull request #18347 * widget props * fix version * Adding app scaffolding for rundeck * Merging pull request #18378 * Update Taiga component with new actions and sources - Bump version to 0.1.0 in package.json and add dependency on @pipedream/platform. - Introduce new actions for creating, updating, and deleting issues, tasks, and user stories. - Add sources for tracking changes and deletions of issues and tasks. - Implement utility functions for parsing and cleaning objects in common/utils.mjs. - Enhance prop definitions for better integration with Taiga API. * pnpm update * Refactor Taiga actions to utilize parseObject utility - Added parseObject utility for tags, watchers, and points in update-issue, update-task, and update-userstory actions. - Removed the update-project action as it is no longer needed. - Enhanced base source to include secret key validation for webhook security. * Merging pull request #18382 * add testSources prop * pnpm-lock.yaml * fix * Merging pull request #18323 * Added actions * Added actions * Added actions * Merging pull request #18377 * Added actions * Update components/weaviate/actions/create-class/create-class.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Luan Cazarine <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Merging pull request #18376 * Adding app scaffolding for etrusted * Adding app scaffolding for intelliflo_office * Adding app scaffolding for thoughtspot * Adding app scaffolding for kordiam * Adding app scaffolding for ticketsauce * trustpilot fixes (#18152) * trustpilot fixes * more fixes * update versions * more version updates * fixes * Bump all Trustpilot actions to version 0.1.0 Major improvements and API updates across all actions: - Enhanced private API support with proper authentication - Improved parameter handling and validation - Better error handling and response structures - Added new conversation flow for product reviews - Fixed endpoint URLs to match latest API documentation - Streamlined request/response processing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * up version and clean up sources * merge * fix business ID * delete temp action * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-service-reviews/new-service-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * comments * Pagination * fixes * comments * missed some `$`'s * unduplicated * more fixes * final comments * more comments * . --------- Co-authored-by: Claude <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Adding app scaffolding for peekalink * 18314 twilio (#18350) * Update Twilio component versions and dependencies - Update Twilio Send Message action adding detailed description for 'from' prop and refactoring phone number validation logic. - Incremented action versions for several Twilio actions. * pnpm update * Updating LinkedIn API version (#18399) * Merging pull request #18394 * Databricks API - Jobs action components (#18371) * Notion property building improvements (#18381) * validate property types * versions * Google Business - add debug log (#18407) * add debug log * bump versions * Notion API Key - update @pipedream/notion version (#18409) * update @pipedream/notion dependency version * pnpm-lock.yaml * Adding app scaffolding for reduct_video * Adding app scaffolding for shopware * Adding app scaffolding for instamojo * Hubspot - bug fix to sources w/ property changes (#18379) * updates * versions * Google sheets type fix (#18411) * Fixing worksheetId prop type from string to integer * Version bumps --------- Co-authored-by: Leo Vu <[email protected]> * Merging pull request #18393 * new components * remove console.log * versions * update * Merging pull request #18408 * 403 error message * versions * update * Merging pull request #18419 * Changes per PR Review * Removes leonardo_ai_actions.mdc not indented for merging * synced lockfile after install * fully lock form-data for leonardo_ai * conflict solving * lint fixes * Chipped down Readme, implemented async options in gen motion --------- Co-authored-by: jocarino <[email protected]> Co-authored-by: joao <[email protected]> Co-authored-by: joaocoform <[email protected]> Co-authored-by: Jorge Cortes <[email protected]> Co-authored-by: Michelle Bergeron <[email protected]> Co-authored-by: Luan Cazarine <[email protected]> Co-authored-by: michelle0927 <[email protected]> Co-authored-by: Andrew Chuang <[email protected]> Co-authored-by: danhsiung <[email protected]> Co-authored-by: Lucas Caresia <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Job <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Guilherme Falcão <[email protected]> Co-authored-by: Leo Vu <[email protected]>
The worksheetId prop is an integer, but was typed as a string.
This did not result in any bugs due to the property not being manipulated before being sent to the API, but it was reported by a user and may cause issues when validating values.
Summary by CodeRabbit
Bug Fixes
Chores