-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Make Register MU timeout #17910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Register MU timeout #17910
Conversation
…1 to assets/MicrosoftUpdate/RegisterMicrosoftUpdate.ps1
anamnavi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I don't think the installation should fail in its entirety. A warning for interactive install should be enough. |
Co-authored-by: Aditya Patwardhan <[email protected]>
Co-authored-by: Aditya Patwardhan <[email protected]>
Either it passes or fails. We don't have any other option. This portion of the installation is never interactive. MSI has two phases, parameter gathering and installation. Only the parameter gathering phase is ever interactive. The other option is to make it fail silently which I don't think is reasonable. |
|
Actually, I was looking at the code and return code is already ignored. So, we already ignore the failure. This just fixes the hang. PowerShell/assets/wix/Product.wxs Line 95 in 9c14a5d
|
| # Licensed under the MIT License. | ||
|
|
||
| param( | ||
| [ValidateSet('Registration', 'Sleep', 'Fail')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [ValidateSet('Registration', 'Sleep', 'Fail')] | |
| [ValidateSet('Hang', 'Fail')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we removed Hang term from our C# files for compliance. Can we use the term here?
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Lets wait on releasing this in a preview to validate the change. |
|
/backport to release/v7.3.0-rc.1 |
|
🎉 Handy links: |
PR Summary
Create a script that stops the Microsoft Update registration Custom Action and fails the installation if it takes too long.
PR Context
Fixes #17899
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).