Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Aug 16, 2022

PR Summary

Create a script that stops the Microsoft Update registration Custom Action and fails the installation if it takes too long.

PR Context

Fixes #17899

PR Checklist

Copy link
Member

@anamnavi anamnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agowa
Copy link

agowa commented Aug 17, 2022

I don't think the installation should fail in its entirety. A warning for interactive install should be enough.

@TravisEz13
Copy link
Member Author

TravisEz13 commented Aug 17, 2022

@agowa338

I don't think the installation should fail in its entirety. A warning for interactive installation should be enough.

Either it passes or fails. We don't have any other option. This portion of the installation is never interactive. MSI has two phases, parameter gathering and installation. Only the parameter gathering phase is ever interactive.

The other option is to make it fail silently which I don't think is reasonable.

@TravisEz13 TravisEz13 marked this pull request as ready for review August 17, 2022 19:32
@TravisEz13
Copy link
Member Author

Actually, I was looking at the code and return code is already ignored. So, we already ignore the failure. This just fixes the hang.

Return="ignore"

# Licensed under the MIT License.

param(
[ValidateSet('Registration', 'Sleep', 'Fail')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[ValidateSet('Registration', 'Sleep', 'Fail')]
[ValidateSet('Hang', 'Fail')]

Copy link
Collaborator

@iSazonov iSazonov Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we removed Hang term from our C# files for compliance. Can we use the term here?

@pull-request-quantifier-deprecated

This PR has 58 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +56 -2
Percentile : 23.2%

Total files changed: 4

Change summary by file extension:
.ps1 : +50 -0
.wxs : +5 -1
.csproj : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 18, 2022
@TravisEz13 TravisEz13 merged commit 378ce9f into master Aug 18, 2022
@TravisEz13 TravisEz13 deleted the Make-Register-MU-Timeout branch August 18, 2022 16:47
@adityapatwardhan
Copy link
Member

Lets wait on releasing this in a preview to validate the change.

@adityapatwardhan
Copy link
Member

/backport to release/v7.3.0-rc.1

@ghost
Copy link

ghost commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PowerShell setup gets stuck on windows update registration when WU Service data base is corrupt

8 participants