Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[8.2] Fix "has map" performance - [MOD-9687] #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
redisearch-backport-pull-request merged 2 commits into from
Aug 13, 2025
Merged

[8.2] Fix "has map" performance - [MOD-9687] #6648

redisearch-backport-pull-request merged 2 commits into from
Aug 13, 2025

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Aug 13, 2025

Description

Backport of #6636 to 8.2.

GuyAv46 added 2 commits August 13, 2025 13:34
@GuyAv46 @github-actions
use cached value
5d8b894 
(cherry picked from commit 4ab8955)
@GuyAv46 @github-actions
make inline
ce2b08b 
(cherry picked from commit e3082eb)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request Aug 13, 2025
Merged
2 tasks
@fcostaoliveira
Copy link
Contributor

fcostaoliveira commented Aug 13, 2025 •
edited
Loading

Automated performance analysis summary

This comment was automatically generated given there is performance data available.

In summary:

  • Detected a total of 29 stable tests between versions.
  • Detected a total of 4 highly unstable benchmarks (4 baseline).
  • Latency analysis confirmed regressions in 2 of the unstable tests:
  • Detected a total of 2 improvements above the improvement water line.
  • Detected a total of 5 regressions bellow the regression water line 8.0.

You can check a comparison in detail via the grafana link

Performance Improvements - Comparison between 8.2 and backport-6636-to-8.2.

Time Period from 30 days ago. (environment used: oss-standalone)

Test Case Baseline 8.2 (median obs. +- std.dev) Comparison backport-6636-to-8.2 (median obs. +- std.dev) % change (higher-better) Note
search-ftsb-10K-enwiki_abstract-hashes-term-withsuffix-trie 46990 +- 5.7% (7 datapoints) 53045 12.9% IMPROVEMENT
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-union-query 3343 +- 9.3% (7 datapoints) 3678 10.0% waterline=9.3%. IMPROVEMENT

Performance Regressions and Issues - Comparison between 8.2 and backport-6636-to-8.2.

Time Period from 30 days ago. (environment used: oss-standalone)

Test Case Baseline 8.2 (median obs. +- std.dev) Comparison backport-6636-to-8.2 (median obs. +- std.dev) % change (higher-better) Note
search-numeric 5011 +- 9.5% (7 datapoints) 2315 -53.8% waterline=9.5%. REGRESSION
search-numeric-sortby 4084 +- 28.1% UNSTABLE (7 datapoints) 2379 -41.7% UNSTABLE (baseline high variance); server: FT.SEARCH p50 increased 74.1% (baseline CV=35.4%); client: Latency increased 71.7% (baseline CV=34.5%)
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-intersection-query 329 +- 8.6% (7 datapoints) 253 -23.0% waterline=8.6%. REGRESSION
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-union-query-non-sortable 1106 +- 4.5% (7 datapoints) 956 -13.5% REGRESSION
search-high-cardinality-negation-term-baseline 29 +- 3.2% (7 datapoints) 25 -13.3% REGRESSION
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-numeric-filter 171 +- 10.5% UNSTABLE (7 datapoints) 155 -9.7% UNSTABLE (baseline high variance); server: FT.SEARCH p50 increased 10.1% (baseline CV=13.8%); client: Latency increased 11.1% (baseline CV=13.1%)
ftsb-1M-enwiki_abstract-hashes-load 22930 +- 3.5% (7 datapoints) 20978 -8.5% REGRESSION
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-intersection-query-non-sortable 31 +- 19.3% UNSTABLE (7 datapoints) 40 27.2% UNSTABLE (baseline high variance); server: FT.SEARCH p50 decreased 20.5% (baseline CV=9.4%); client: client latency stable; neither server nor client side confirms regression
search-numeric-sortby-desc 2236 +- 55.1% UNSTABLE (7 datapoints) 4860 117.3% UNSTABLE (baseline high variance); server: FT.SEARCH p50 decreased 55.3% (baseline CV=36.8%); client: Latency decreased 54.0% (baseline CV=35.4%); neither server nor client side confirms regression
Tests with No Significant Changes (29 tests)

Tests with No Significant Changes

Test Case Baseline 8.2 (median obs. +- std.dev) Comparison backport-6636-to-8.2 (median obs. +- std.dev) % change (higher-better) Note
ftsb-10K-enwiki_abstract-hashes-fulltext-sortby 87 +- 2.3% (7 datapoints) 85.00 -1.9% No Change
ftsb-10K-enwiki_abstract-hashes-term-prefix 8836 +- 6.2% (7 datapoints) 8929.00 1.1% No Change
ftsb-10K-enwiki_abstract-hashes-term-suffix 2729 +- 0.9% (7 datapoints) 2761.00 1.2% No Change
ftsb-10K-enwiki_abstract-hashes-term-suffix-withsuffixtrie 85791 +- 3.7% (7 datapoints) 84038.00 -2.0% No Change
ftsb-10K-enwiki_abstract-hashes-term-wildcard 15014 +- 6.4% (7 datapoints) 15392.00 2.5% No Change
ftsb-10K-enwiki_pages-hashes-fulltext-mixed_simple-1word-query_write_1_to_read_20.yml 1087 +- 5.8% (7 datapoints) 1122.00 3.2% potential IMPROVEMENT
ftsb-10K-enwiki_pages-hashes-load 61917 +- 5.1% (7 datapoints) 66726.00 7.8% potential IMPROVEMENT
ftsb-10K-multivalue-numeric-json 983 +- 0.8% (7 datapoints) 969.00 -1.4% No Change
ftsb-10K-singlevalue-numeric-json 455 +- 0.7% (7 datapoints) 449.00 -1.2% No Change
ftsb-1K-enwiki_abstract-hashes-term-contains 2266 +- 0.9% (7 datapoints) 2277.00 0.5% No Change
ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query 1048 +- 3.2% (7 datapoints) 1009.00 -3.7% potential REGRESSION
ftsb-1M-nyc_taxis-ftadd-load 29126 +- 2.4% (7 datapoints) 27577.00 -5.3% potential REGRESSION
ftsb-1M-nyc_taxis-hashes-load 32689 +- 3.1% (7 datapoints) 32968.00 0.9% No Change
search-aggregate-post-filter-simple.yml 122448 +- 8.9% (7 datapoints) 131588.00 7.5% waterline=8.9%. potential IMPROVEMENT
search-filtering-tag-numeric 238 +- 9.6% (7 datapoints) 224.00 -5.7% waterline=9.6%. potential REGRESSION
search-filtering-tag-numeric-filter-pipeline 26468 +- 3.0% (7 datapoints) 27033.00 2.1% No Change
search-ftsb-10K-enwiki_abstract-hashes-term-withoutsuffix-trie 47364 +- 6.0% (7 datapoints) 50699.00 7.0% potential IMPROVEMENT
search-ftsb-1700K-docs-union-iterators-q3 8.1 +- 1.2% (7 datapoints) 8.00 -2.0% No Change
search-ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query-non-sortable 156 +- 5.3% (7 datapoints) 167.00 6.9% potential IMPROVEMENT
search-ftsb-370K-docs-union-iterators-q4 8.3 +- 0.6% (7 datapoints) 8.30 -0.2% No Change
search-ftsb-5200K-docs-union-iterators-q1 0.86 +- 1.1% (7 datapoints) 0.84 -2.3% No Change
search-ftsb-5500K-docs-union-iterators-q2 1.2 +- 0.7% (7 datapoints) 1.20 0.8% No Change
search-geo 217 +- 6.0% (7 datapoints) 200.00 -7.6% potential REGRESSION
search-high-cardinality-negation-term-comparison_union_all_other_terms 8.8 +- 1.1% (7 datapoints) 8.40 -4.0% potential REGRESSION
search-numeric-optimize 14128 +- 2.1% (7 datapoints) 14567.00 3.1% potential IMPROVEMENT
search-numeric-sortby-desc-optimize 28 +- 4.2% (7 datapoints) 28.00 2.6% No Change
search-numeric-sortby-optimize 26 +- 6.7% (7 datapoints) 26.00 -1.6% No Change
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-fulltext-filter 632 +- 4.5% (7 datapoints) 589.00 -6.7% potential REGRESSION
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-tag-filter 76108 +- 6.1% (7 datapoints) 74566.00 -2.0% No Change

@codecov
Copy link

codecov bot commented Aug 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.43%. Comparing base (dba8dd0) to head (ce2b08b).
⚠️ Report is 3 commits behind head on 8.2.

Additional details and impacted files 
@@            Coverage Diff             @@
##              8.2    #6648      +/-   ##
==========================================
- Coverage   89.46%   89.43%   -0.03%     
==========================================
  Files         253      253              
  Lines       41613    41613              
  Branches     3725     3725              
==========================================
- Hits        37228    37216      -12     
- Misses       4336     4348      +12     
  Partials       49       49
Flag Coverage Δ
flow 82.01% <100.00%> (-0.15%) ⬇️
unit 47.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Aug 13, 2025
Merged via the queue into 8.2 with commit 9d28cdf Aug 13, 2025
55 of 66 checks passed
@redisearch-backport-pull-request redisearch-backport-pull-request bot deleted the backport-6636-to-8.2 branch August 13, 2025 15:18
@YaacovHazan YaacovHazan mentioned this pull request Sep 28, 2025
Merged
YaacovHazan pushed a commit to redis/redis that referenced this pull request Sep 28, 2025
@oshadmi
MOD-11572: Bump RediSearch to v8.2.5 for Redis 8.2.2 (#14388)
9bd3d24 
$ gitlog v8.2.1..v8.2.5

RediSearch/RediSearch#6867 Improve BUILD_INTEL_SVS_OPT flag validation
RediSearch/RediSearch#6845 Fix vector compression type reporting and
rename SVS environment variable
RediSearch/RediSearch#6794 Fix rpcountFree casting
RediSearch/RediSearch#6825 Bump vecsim 8.2.4
RediSearch/RediSearch#6787 Fix deadlock while RDB loading and RM_Yield
(#6763)
RediSearch/RediSearch#6723 Fix ACLUserMayAccessIndex
RediSearch/RediSearch#6701 Fix fd leak when OOM
RediSearch/RediSearch#6676 bump svs version
RediSearch/RediSearch#6671 Add SVS-VAMANA index to info fields telemetry
RediSearch/RediSearch#6665 Optimize rs_wall_clock_diff_ns by removing
redundant if branch
RediSearch/RediSearch#6641 Update vectors memory in total index info
memory
RediSearch/RediSearch#6634 Log DocTable capacity growth for memory
diagnostics
RediSearch/RediSearch#6649 Bump minimal redis version
RediSearch/RediSearch#6648 Fix "has map" performance
RediSearch/RediSearch#6645 Trie: hide expensive memory usage computation
behind a test-specific feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuyAv46 GuyAv46 GuyAv46 approved these changes

Assignees

No one assigned

Labels

action:run-benchmark bug size:XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fcostaoliveira @GuyAv46