[8.2] [MOD-11011] Fix deadlock while RDB loading and RM_Yield (#6763) #6787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test file trying to reproduce lock * test RDB update * try the test changes * only keep test changes * remove some logs * fix: Yield to Redis before acquiring Write Lock * proper Lock initialization on RDB load * proper initialization * remove test file * remove comment from code * add numOps instead of reducing Yield frequency * move lock init * add DEBUG command to improve testing * fix failing tests * remove added tests by mistake (cherry picked from commit 4710f44)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.2 #6787 +/- ##
==========================================
- Coverage 89.47% 89.43% -0.04%
==========================================
Files 253 253
Lines 41626 41651 +25
Branches 3725 3725
==========================================
+ Hits 37245 37251 +6
- Misses 4332 4351 +19
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Sep 7, 2025
YaacovHazan
pushed a commit
to redis/redis
that referenced
this pull request
Sep 28, 2025
$ gitlog v8.2.1..v8.2.5 RediSearch/RediSearch#6867 Improve BUILD_INTEL_SVS_OPT flag validation RediSearch/RediSearch#6845 Fix vector compression type reporting and rename SVS environment variable RediSearch/RediSearch#6794 Fix rpcountFree casting RediSearch/RediSearch#6825 Bump vecsim 8.2.4 RediSearch/RediSearch#6787 Fix deadlock while RDB loading and RM_Yield (#6763) RediSearch/RediSearch#6723 Fix ACLUserMayAccessIndex RediSearch/RediSearch#6701 Fix fd leak when OOM RediSearch/RediSearch#6676 bump svs version RediSearch/RediSearch#6671 Add SVS-VAMANA index to info fields telemetry RediSearch/RediSearch#6665 Optimize rs_wall_clock_diff_ns by removing redundant if branch RediSearch/RediSearch#6641 Update vectors memory in total index info memory RediSearch/RediSearch#6634 Log DocTable capacity growth for memory diagnostics RediSearch/RediSearch#6649 Bump minimal redis version RediSearch/RediSearch#6648 Fix "has map" performance RediSearch/RediSearch#6645 Trie: hide expensive memory usage computation behind a test-specific feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.