Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: report coverage from meteor unit tests #35939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 7, 2025

While working on issue #35937, I noticed that my tests had no impact on the coverage report. This led me to conclude that something was wrong.

https://rocketchat.atlassian.net/browse/ARCH-1596

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments


This pull request updates the Jest configuration in the apps/meteor/jest.config.ts file of the Rocket.Chat repository. The changes are aimed at reporting coverage from Meteor unit tests by modifying the coverage path ignore patterns and enabling coverage collection. The source branch for this update is test/coverage-unit-test, and it is intended to be merged into the develop branch.

Copy link
Contributor

dionisio-bot bot commented May 7, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: 7bd698a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

kodus-ai bot commented May 7, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

},
],
coverageProvider: 'v8',
collectCoverage: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Maintainability medium

collectCoverage: true

Enabling collectCoverage globally ensures that coverage data is collected for all tests, which is essential for maintaining code quality.

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

Copy link
Contributor

github-actions bot commented May 7, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35939/

Built to branch gh-pages at 2025-05-07 03:06 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.57%. Comparing base (b2fad33) to head (7bd698a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35939      +/-   ##
===========================================
+ Coverage    61.28%   64.57%   +3.28%     
===========================================
  Files         3164     3222      +58     
  Lines        74803    95187   +20384     
  Branches     16693    17831    +1138     
===========================================
+ Hits         45846    61467   +15621     
- Misses       25854    30827    +4973     
+ Partials      3103     2893     -210     
Flag Coverage Δ
e2e 58.07% <ø> (-0.01%) ⬇️
unit 71.85% <ø> (-3.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.7.0 milestone May 7, 2025
@ggazzo ggazzo marked this pull request as ready for review May 7, 2025 12:09
@ggazzo ggazzo merged commit 61991e9 into develop May 7, 2025
56 checks passed
@ggazzo ggazzo deleted the test/coverage-unit-test branch May 7, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants