-
Notifications
You must be signed in to change notification settings - Fork 11.7k
test: report coverage from meteor unit tests #35939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
}, | ||
], | ||
coverageProvider: 'v8', | ||
collectCoverage: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collectCoverage: true
Enabling collectCoverage globally ensures that coverage data is collected for all tests, which is essential for maintaining code quality.
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35939 +/- ##
===========================================
+ Coverage 61.28% 64.57% +3.28%
===========================================
Files 3164 3222 +58
Lines 74803 95187 +20384
Branches 16693 17831 +1138
===========================================
+ Hits 45846 61467 +15621
- Misses 25854 30827 +4973
+ Partials 3103 2893 -210
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
While working on issue #35937, I noticed that my tests had no impact on the coverage report. This led me to conclude that something was wrong.
https://rocketchat.atlassian.net/browse/ARCH-1596
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This pull request updates the Jest configuration in the
apps/meteor/jest.config.ts
file of the Rocket.Chat repository. The changes are aimed at reporting coverage from Meteor unit tests by modifying the coverage path ignore patterns and enabling coverage collection. The source branch for this update istest/coverage-unit-test
, and it is intended to be merged into thedevelop
branch.