Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Unify usage of openAppSettings #6252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
diegolmello opened this issue Mar 21, 2025 · 2 comments · May be fixed by #6253
Open

chore: Unify usage of openAppSettings #6252

diegolmello opened this issue Mar 21, 2025 · 2 comments · May be fixed by #6253
Labels
🚚 chore 🍭 good first issue

Comments

@diegolmello
Copy link
Member

Search for app-settings: and you'll find this

Image

We have openAppSettings though, so we should use it in those places.
https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/b1105102f9b2a13b40970b31a6fc011ca9bad158/app/lib/methods/helpers/openAppSettings.ts

Also notice it's a promise. We should handle it.
@Rohit3523
Copy link
Contributor

But the return type is void in openAppSettings 👀

@Rohit3523 Rohit3523 linked a pull request Mar 21, 2025 that will close this issue
Open
10 tasks
@diegolmello
Copy link
Member Author

@Rohit3523 yeah, it's wrong, but it's also not the end of the world.
Either options are valid, but I prefer the second one to make it easier.
Just don't forget to await on caller.

Image

@samir0607 samir0607 mentioned this issue Mar 22, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚚 chore 🍭 good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use open app settings Rohit3523/Rocket.Chat.ReactNative
2 participants
@diegolmello @Rohit3523