-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use open app settings #6253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rohit3523
wants to merge
10
commits into
RocketChat:develop
Choose a base branch
from
Rohit3523:use-open-app-settings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use open app settings #6253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95d011b
to
78d1984
Compare
diegolmello
requested changes
Mar 21, 2025
app/views/PushTroubleshootView/components/DeviceNotificationSettings.tsx
Outdated
Show resolved
Hide resolved
10 tasks
Requesting a review, Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We already have
openAppSettings
function which handle the linking of app-settings, instead of using app-settings in multiple places, we can just call the app settings function.Issue(s)
Closes: #6252
How to test or reproduce
N/A
Screenshots
N/A
Types of changes
Checklist
Further comments
N/A