Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use open app settings #6253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Rohit3523
Copy link
Contributor

Proposed changes

We already have openAppSettings function which handle the linking of app-settings, instead of using app-settings in multiple places, we can just call the app settings function.

Issue(s)

Closes: #6252

How to test or reproduce

N/A

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@Rohit3523 Rohit3523 force-pushed the use-open-app-settings branch from 95d011b to 78d1984 Compare March 21, 2025 16:49
@Rohit3523 Rohit3523 requested a review from diegolmello March 28, 2025 15:14
@Rohit3523
Copy link
Contributor Author

Requesting a review, Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Unify usage of openAppSettings
2 participants