Run test suites like how CPython runs theirs #3807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46657ba to
43a68ab
Compare
|
I can investigate the Windows failures tomorrow evening. |
The extra flags come from the `buildbottest` rule in CPython's Makefile. This will enable checking the tests we've been skipping by default (such as network-based tests). This will also report the top 10 slowest tests and will mark a test as failed if it altered the execution environment.
c758ea0 to
e850b6e
Compare
"ValueError: illegal environment variable name" likely comes from the `--fail-env-changed` switch we're now using.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra flags come from the
buildbottestrule in CPython's Makefile.This will enable checking the tests we've been skipping by default (such as network-based tests). This will also report the top 10 slowest tests and will mark a test as failed if it altered the execution environment.