-
Notifications
You must be signed in to change notification settings - Fork 44
Change mod_fluka error handling, fix DA version #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
source/mod_fluka.f90
Outdated
write(lerr,'(A)')'FLUKA> ERROR -1 in Fluka communication returned by fluka_send_receive...' | ||
write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_send_receive...' | ||
if (ret.lt.0) then | ||
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret, ' in Fluka communication returned by fluka_send_receive...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use format i0
so there is no chance of ****
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. @vkbo - even though I don't think we will have many error codes, but it is better to set it once correctly forever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only minor things
#include "include/dalin3.f90" | ||
#include "include/dalin4.f90" | ||
#include "include/dalin5.f90" | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Thanks, God, it's Christmas!" (the Queen)
source/mod_fluka.f90
Outdated
write(lerr,'(A)')'FLUKA> ERROR -1 in Fluka communication returned by fluka_send_receive...' | ||
write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_send_receive...' | ||
if (ret.lt.0) then | ||
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret, ' in Fluka communication returned by fluka_send_receive...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. @vkbo - even though I don't think we will have many error codes, but it is better to set it once correctly forever.
source/mod_fluka.f90
Outdated
n = ntsendeoc(fluka_cid) | ||
if(n.lt.0) then | ||
write(fluka_log_unit,*) "# FlukaIO error: Error sending End of Computation" | ||
write(fluka_log_unit,*) "# FlukaIO error: ", n, " - Error sending End of Computation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(fluka_log_unit,'(A,i0,A)')
source/mod_fluka.f90
Outdated
if(n.eq.-1) then | ||
write(fluka_log_unit,*) "# FlukaIO error: Server timed out while waiting End of Computation" | ||
if(n.lt.0) then | ||
write(fluka_log_unit,*) "# FlukaIO error: ", n, " - Server timed out while waiting End of Computation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(fluka_log_unit,'(A,i0,A)')
source/mod_fluka.f90
Outdated
if(n.eq.-1) then | ||
write(fluka_log_unit,*) "# FlukaIO error: Error sending Insertion Point" | ||
if(n.lt.0) then | ||
write(fluka_log_unit,*) "# FlukaIO error: ", n, " - Error sending Insertion Point" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(fluka_log_unit,'(A,i0,A)')
source/mod_fluka.f90
Outdated
|
||
if(n.lt.0) then | ||
write(fluka_log_unit,*) "# FlukaIO error: Error sending End of Batch" | ||
write(fluka_log_unit,*) "# FlukaIO error: ", n, " - Error sending End of Batch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(fluka_log_unit,'(A,i0,A)')
source/mod_fluka.f90
Outdated
if(n.eq.-1) then | ||
write(fluka_log_unit,*) "# FlukaIO error: Server timed out while waiting for message" | ||
if(n.lt.0) then | ||
write(fluka_log_unit,*) "# FlukaIO error: ", n ," - Server timed out while waiting for message" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(fluka_log_unit,'(A,i0,A)')
source/mod_fluka.f90
Outdated
write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_send_receive...' | ||
if (ret.lt.0) then | ||
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret, ' in Fluka communication returned by fluka_send_receive...' | ||
write(fluka_log_unit,'(A,i4,A)')'# Error ', ret, ' in Fluka communication returned by fluka_send_receive...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(fluka_log_unit,'(A,i0,A)')
source/mod_fluka.f90
Outdated
write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_send...' | ||
if (ret.lt.0) then | ||
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret,' in Fluka communication returned by fluka_send...' | ||
write(fluka_log_unit,'(A,i4,A)')'# Error ', ret, ' in Fluka communication returned by fluka_send...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(fluka_log_unit,'(A,i0,A)')
source/mod_fluka.f90
Outdated
write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_receive...' | ||
if (ret.lt.0) then | ||
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret, ' in Fluka communication returned by fluka_receive...' | ||
write(fluka_log_unit,'(A,i4,A)')'# Error ',ret, ' in Fluka communication returned by fluka_receive...' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(fluka_log_unit,'(A,i0,A)')
No description provided.