Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

JamesMolson
Copy link
Contributor

No description provided.

@JamesMolson JamesMolson requested a review from amereghe December 17, 2019 11:04
write(lerr,'(A)')'FLUKA> ERROR -1 in Fluka communication returned by fluka_send_receive...'
write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_send_receive...'
if (ret.lt.0) then
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret, ' in Fluka communication returned by fluka_send_receive...'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use format i0 so there is no chance of ****?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. @vkbo - even though I don't think we will have many error codes, but it is better to set it once correctly forever.

Copy link
Contributor

@amereghe amereghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor things

#include "include/dalin3.f90"
#include "include/dalin4.f90"
#include "include/dalin5.f90"
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Thanks, God, it's Christmas!" (the Queen)

write(lerr,'(A)')'FLUKA> ERROR -1 in Fluka communication returned by fluka_send_receive...'
write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_send_receive...'
if (ret.lt.0) then
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret, ' in Fluka communication returned by fluka_send_receive...'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. @vkbo - even though I don't think we will have many error codes, but it is better to set it once correctly forever.

n = ntsendeoc(fluka_cid)
if(n.lt.0) then
write(fluka_log_unit,*) "# FlukaIO error: Error sending End of Computation"
write(fluka_log_unit,*) "# FlukaIO error: ", n, " - Error sending End of Computation"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write(fluka_log_unit,'(A,i0,A)')

if(n.eq.-1) then
write(fluka_log_unit,*) "# FlukaIO error: Server timed out while waiting End of Computation"
if(n.lt.0) then
write(fluka_log_unit,*) "# FlukaIO error: ", n, " - Server timed out while waiting End of Computation"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write(fluka_log_unit,'(A,i0,A)')

if(n.eq.-1) then
write(fluka_log_unit,*) "# FlukaIO error: Error sending Insertion Point"
if(n.lt.0) then
write(fluka_log_unit,*) "# FlukaIO error: ", n, " - Error sending Insertion Point"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write(fluka_log_unit,'(A,i0,A)')


if(n.lt.0) then
write(fluka_log_unit,*) "# FlukaIO error: Error sending End of Batch"
write(fluka_log_unit,*) "# FlukaIO error: ", n, " - Error sending End of Batch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write(fluka_log_unit,'(A,i0,A)')

if(n.eq.-1) then
write(fluka_log_unit,*) "# FlukaIO error: Server timed out while waiting for message"
if(n.lt.0) then
write(fluka_log_unit,*) "# FlukaIO error: ", n ," - Server timed out while waiting for message"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write(fluka_log_unit,'(A,i0,A)')

write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_send_receive...'
if (ret.lt.0) then
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret, ' in Fluka communication returned by fluka_send_receive...'
write(fluka_log_unit,'(A,i4,A)')'# Error ', ret, ' in Fluka communication returned by fluka_send_receive...'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write(fluka_log_unit,'(A,i0,A)')

write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_send...'
if (ret.lt.0) then
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret,' in Fluka communication returned by fluka_send...'
write(fluka_log_unit,'(A,i4,A)')'# Error ', ret, ' in Fluka communication returned by fluka_send...'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write(fluka_log_unit,'(A,i0,A)')

write(fluka_log_unit,'(A)')'# Error -1 in Fluka communication returned by fluka_receive...'
if (ret.lt.0) then
write(lerr,'(A,i4,A)')'FLUKA> ERROR ', ret, ' in Fluka communication returned by fluka_receive...'
write(fluka_log_unit,'(A,i4,A)')'# Error ',ret, ' in Fluka communication returned by fluka_receive...'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write(fluka_log_unit,'(A,i0,A)')

@vkbo vkbo merged commit 95b67ca into SixTrack:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants