-
-
Notifications
You must be signed in to change notification settings - Fork 406
Fix function overloading for convertable arguments #8046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
Jul 16, 2025
APickledWalrus
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine
src/main/java/ch/njol/skript/lang/function/FunctionRegistry.java
Outdated
Show resolved
Hide resolved
1 task
Absolutionism
requested changes
Jul 17, 2025
src/test/java/ch/njol/skript/lang/function/FunctionRegistryTest.java
Outdated
Show resolved
Hide resolved
…t.java Co-authored-by: SirSmurfy2 <[email protected]>
…s' into patch/fix-supertypes-and-literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adds support for specifying overloading functions with arguments that have converters to each other.
Solution
Adds a method for getting signatures without converting types.
Testing Completed
Supporting Information
Completes: #8042
Related: none