Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Efnilite
Copy link
Member

Problem

Adds support for specifying overloading functions with arguments that have converters to each other.

Solution

Adds a method for getting signatures without converting types.

Testing Completed

  • Added JUnit test for getExactSignature
  • Added CI test
  • Manually tested with players

Supporting Information


Completes: #8042
Related: none

@Efnilite Efnilite requested a review from a team as a code owner July 16, 2025 13:45
@Efnilite Efnilite added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.12 Targeting a 2.12.X version release. Project ID: 7 labels Jul 16, 2025
@Efnilite Efnilite requested review from Burbulinis and TheMug06 and removed request for a team July 16, 2025 13:45
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 16, 2025
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine

@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Jul 17, 2025
@skriptlang-automation skriptlang-automation bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jul 17, 2025
@APickledWalrus APickledWalrus moved this to In Review in 2.12 Releases Jul 17, 2025
@APickledWalrus APickledWalrus moved this from In Review to Awaiting Merge in 2.12 Releases Jul 17, 2025
@Efnilite Efnilite requested a review from Absolutionism July 18, 2025 12:48
@APickledWalrus APickledWalrus merged commit b4a514a into dev/patch Jul 24, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Released in 2.12 Releases Jul 24, 2025
@APickledWalrus APickledWalrus deleted the patch/fix-supertypes-and-literals branch July 24, 2025 15:46
@APickledWalrus APickledWalrus moved this from Done - Released to Done - Awaiting Release in 2.12 Releases Jul 24, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.12 Releases Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12 Targeting a 2.12.X version release. Project ID: 7 bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
Status: Done - Released
Development

Successfully merging this pull request may close these issues.

Overloaded functions where one argument is a supertype of the other mistakenly errors.
4 participants