Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[API]adding promotions with expire date #12025

Merged
GSadee merged 3 commits into
Sylius:masterfrom
arti0090:api-promotions-with-exp-date
Nov 11, 2020
Merged

[API]adding promotions with expire date #12025
GSadee merged 3 commits into
Sylius:masterfrom
arti0090:api-promotions-with-exp-date

Conversation

@arti0090
Copy link
Copy Markdown
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets #12013 like this but better
License MIT

@arti0090 arti0090 added Feature New feature proposals. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). API APIs related issues and PRs. labels Nov 10, 2020
@arti0090 arti0090 requested a review from a team as a code owner November 10, 2020 10:00
Comment thread src/Sylius/Bundle/ApiBundle/CommandHandler/Cart/ApplyCouponToCartHandler.php Outdated
@arti0090 arti0090 force-pushed the api-promotions-with-exp-date branch from e90ef48 to 03c001e Compare November 11, 2020 09:36
@arti0090 arti0090 force-pushed the api-promotions-with-exp-date branch from 03c001e to 1d5617e Compare November 11, 2020 09:38
Comment thread src/Sylius/Bundle/ApiBundle/Resources/config/services/validator.xml Outdated
Comment thread src/Sylius/Bundle/PromotionBundle/Resources/translations/validators.en.yml Outdated
@GSadee GSadee merged commit 2b7b075 into Sylius:master Nov 11, 2020
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Nov 11, 2020

Thank you, @arti0090! 🎉

Zales0123 added a commit that referenced this pull request Nov 13, 2020
…ti0090)

This PR was merged into the 1.9-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master 
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes to #12025
| License         | MIT



Commits
-------

ea0c326 qa fixes to feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Feature New feature proposals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants