Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bugfix | Don't declare default_bus for Messenger & always use Sylius Bus#12561

Closed
stloyd wants to merge 1 commit into
Sylius:1.12from
stloyd:bugfix/default-messenger-bus
Closed

Bugfix | Don't declare default_bus for Messenger & always use Sylius Bus#12561
stloyd wants to merge 1 commit into
Sylius:1.12from
stloyd:bugfix/default-messenger-bus

Conversation

@stloyd
Copy link
Copy Markdown
Contributor

@stloyd stloyd commented Apr 23, 2021

Q A
Branch? 1.10-dev, but possibly lower as well
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Having that framework.messenger.default_bus being set, makes impossible to declared own one & forces to use sylius_default.bus as bus in our project.

@stloyd stloyd requested a review from a team as a code owner April 23, 2021 15:03
@probot-autolabeler probot-autolabeler Bot added the API APIs related issues and PRs. label Apr 23, 2021
@stloyd stloyd changed the title Bugfix | Don't declare default_bus for Messenger & always use Sylius Bus WIP | Bugfix | Don't declare default_bus for Messenger & always use Sylius Bus Apr 23, 2021
@stloyd stloyd force-pushed the bugfix/default-messenger-bus branch from e33ca07 to 05d4ad2 Compare April 23, 2021 15:10
@stloyd stloyd changed the title WIP | Bugfix | Don't declare default_bus for Messenger & always use Sylius Bus Bugfix | Don't declare default_bus for Messenger & always use Sylius Bus Apr 23, 2021
@stloyd stloyd force-pushed the bugfix/default-messenger-bus branch 2 times, most recently from 00c76f7 to 479a5ee Compare April 24, 2021 10:14
@probot-autolabeler probot-autolabeler Bot added the Maintenance CI configurations, READMEs, releases, etc. label Apr 24, 2021
@stloyd stloyd force-pushed the bugfix/default-messenger-bus branch from 479a5ee to e560527 Compare April 24, 2021 10:19
@stloyd
Copy link
Copy Markdown
Contributor Author

stloyd commented Apr 24, 2021

@pamil @GSadee The failed test is due too timeout, all other passed. Can you check & give me feedback, thanks :)

@stloyd
Copy link
Copy Markdown
Contributor Author

stloyd commented May 5, 2021

@pamil @lchrusciel Guys as you soon want to release 1.10 officially, I guess this is must have as it otherwise will broke any project using already messenger.

@stloyd stloyd mentioned this pull request May 6, 2021
Merged
@Rafikooo Rafikooo added Feature New feature proposals. and removed API APIs related issues and PRs. labels Feb 28, 2023
@stloyd stloyd closed this Mar 6, 2023
@stloyd stloyd deleted the bugfix/default-messenger-bus branch March 6, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Feature New feature proposals. Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stloyd @Rafikooo