[Refactor] Unification of buses#12602
Conversation
0403e07 to
ac38028
Compare
GSadee
left a comment
There was a problem hiding this comment.
What about changes in CoreBundle: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/CoreBundle/Resources/config/app/messenger.yaml#L16:L18 ?
The sylius_default.bus is configured in Core as a default bus, but in ApiBundle it is marked as deprecated
|
This still is broken when your existing application has own bus declared, see #12561. |
f9fd215 to
2cc8ced
Compare
|
Hey Joseph, that would be awesome to have it fixed, but we need to declare default bus anyway, due to Symfony constraints. Your proposal has some solution for that, but if we would remove the default bus from the end-users app, it will throw an exception. Therefore, I think we will stay with the current solution, but I may propose docs about changing the default bus. Perhaps, we should wire up Api Platform usage to our busses as well, so the app will not collapse once one will change the default one. |
2cc8ced to
b0044ea
Compare
| sylius.command_bus: &command_bus | ||
| default_middleware: allow_no_handlers | ||
| sylius.event_bus: &event_bus | ||
| default_middleware: allow_no_handlers |
There was a problem hiding this comment.
Is there any issue with the following notation?
| default_middleware: allow_no_handlers | |
| middleware: | |
| - 'allow_no_handlers' |
There was a problem hiding this comment.
yes, application crashes with middleware notation
| sylius_default.bus: *command_bus | ||
| sylius_event.bus: *event_bus |
There was a problem hiding this comment.
I'm not sure if these aliases work properly, did you check that? It looks like new buses are creating here
2282a01 to
c1d9a10
Compare
| <service id="sylius.listener.api_authentication_success_listener" class="Sylius\Bundle\ApiBundle\EventListener\AuthenticationSuccessListener"> | ||
| <argument type="service" id="api_platform.iri_converter" /> | ||
| <tag name="kernel.event_listener" event="lexik_jwt_authentication.on_authentication_success" method="onAuthenticationSuccessResponse" /> | ||
| </service> | ||
|
|
There was a problem hiding this comment.
Why did you remove this listener?
722fb55 to
1943b9e
Compare
afdd62b to
c80e63a
Compare
| "symfony/property-info": "4.4.22 || 5.2.7", | ||
| "symfony/serializer": "4.4.19 || 5.2.2" | ||
| "symfony/serializer": "4.4.19 || 5.2.2", | ||
| "symfony/security-core": "^5.2.6 || ^4.4.21" |
0eb8eca to
17be3c5
Compare
17be3c5 to
19b7cb6
Compare
|
Thanks, @SirDomin! 🥇 |
Uh oh!
There was an error while loading. Please reload this page.