Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Maintenance] Replace dbal conflict with explicit requirement#13252

Merged
Zales0123 merged 1 commit into
Sylius:1.9from
lchrusciel:dbal-conflict
Oct 28, 2021
Merged

[Maintenance] Replace dbal conflict with explicit requirement#13252
Zales0123 merged 1 commit into
Sylius:1.9from
lchrusciel:dbal-conflict

Conversation

@lchrusciel
Copy link
Copy Markdown
Contributor

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets mentioned in #13215 (review)
License MIT

@lchrusciel lchrusciel requested a review from a team as a code owner October 27, 2021 12:37
@probot-autolabeler probot-autolabeler Bot added the Maintenance CI configurations, READMEs, releases, etc. label Oct 27, 2021
@Zales0123 Zales0123 merged commit 4611fd6 into Sylius:1.9 Oct 28, 2021
@Zales0123
Copy link
Copy Markdown
Contributor

Thank you, Łukasz! 🥇

@stloyd
Copy link
Copy Markdown
Contributor

stloyd commented Oct 28, 2021

IMHO that conflict & explain was way more useful than just locking to explicit version, cause with explain, anyone who will struggle to update to v3 will be able to see related problem & issue instead of looking for everything on his/her own...

@lchrusciel lchrusciel deleted the dbal-conflict branch October 28, 2021 08:43
@lchrusciel
Copy link
Copy Markdown
Contributor Author

Hey @stloyd, I can totally understand you. On the contrary, we know, that 2.* is the version supported, but 3.* is not due to the semver. We are basing our build on this explicit version atm.
Perhaps, something similar to the CONFLICT.md file for dependencies log would be useful as well. Or maybe these kinds of changes should be documented in ADRs? What do you think?

@stloyd
Copy link
Copy Markdown
Contributor

stloyd commented Oct 28, 2021

I would say:

So I would suggest:

GSadee added a commit that referenced this pull request Nov 8, 2021
…lchrusciel)

This PR was merged into the 1.9 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.9
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #13252 (comment)
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

cc66b79 [Maintenance] Add note about doctrine/dbal requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants