[Maintenance] Replace dbal conflict with explicit requirement#13252
Merged
Conversation
Contributor
lchrusciel
commented
Oct 27, 2021
| Q | A |
|---|---|
| Branch? | 1.9 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | mentioned in #13215 (review) |
| License | MIT |
Zales0123
approved these changes
Oct 28, 2021
Contributor
|
Thank you, Łukasz! 🥇 |
Contributor
|
IMHO that conflict & explain was way more useful than just locking to explicit version, cause with explain, anyone who will struggle to update to v3 will be able to see related problem & issue instead of looking for everything on his/her own... |
Contributor
Author
|
Hey @stloyd, I can totally understand you. On the contrary, we know, that 2.* is the version supported, but 3.* is not due to the semver. We are basing our build on this explicit version atm. |
Contributor
|
I would say:
So I would suggest:
|
GSadee
added a commit
that referenced
this pull request
Nov 8, 2021
…lchrusciel) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #13252 (comment) | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- cc66b79 [Maintenance] Add note about doctrine/dbal requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.