Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feat: added iterativeFactorial #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 21, 2023
Merged

Feat: added iterativeFactorial #2453

merged 21 commits into from
Jul 21, 2023

Conversation

Renjian-buchai
Copy link
Contributor

Description of Change

Iterative implementation of factorial.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Renjian-buchai Renjian-buchai changed the title Feat: iterativeFactorial Feat: added iterativeFactorial Apr 29, 2023
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a bit of changes to fit to contribution guidelines

Renjian-buchai and others added 2 commits April 29, 2023 22:48
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
wait for a review from @Panquesito7
thank you for your contributions as they are greatly appreciated ❤️

@Panquesito7 Panquesito7 added the enhancement New feature or request label May 26, 2023
Panquesito7
Panquesito7 previously approved these changes May 30, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

tjgurwara99
tjgurwara99 previously approved these changes Jun 5, 2023
@realstealthninja realstealthninja dismissed stale reviews from tjgurwara99 and Panquesito7 via 6039c87 June 16, 2023 10:14
realstealthninja

This comment was marked as resolved.

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! thank you for your contribution and i expect to see more such amazing works from you! ❤️

Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick:

@github-actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Jul 17, 2023
@Panquesito7 Panquesito7 removed the stale Author has not responded to the comments for over 2 weeks label Jul 20, 2023
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely wonderful! thank you so much for your contributions! ❤️

@Panquesito7 Panquesito7 merged commit 17a5326 into TheAlgorithms:master Jul 21, 2023
@Renjian-buchai Renjian-buchai deleted the factorial-iterative branch July 21, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants