-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Feat: added iterativeFactorial #2453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: added iterativeFactorial #2453
Conversation
Docs: Updated docs to to explain why maximum is 20
docs: Added documentation to some functions. test: Added exception test.
…ai/C-Plus-Plus into factorial-iterative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a bit of changes to fit to contribution guidelines
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
wait for a review from @Panquesito7
thank you for your contributions as they are greatly appreciated ❤️
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
Co-authored-by: Taj <[email protected]>
6039c87
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! thank you for your contribution and i expect to see more such amazing works from you! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick:
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely wonderful! thank you so much for your contributions! ❤️
Description of Change
Iterative implementation of factorial.
Checklist
Notes: