Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@acamill
Copy link
Member

@acamill acamill commented Mar 24, 2022

  • Remove Passthrough account in Mint (+client)

Screenshot 2022-03-24 at 15 57 38

  • Remove passthrough account in Redeem (+client)

Screenshot 2022-03-24 at 16 10 18

  • Remove passthrough accounts in Rebalancing (+client)

Screenshot 2022-03-24 at 16 27 39

  • Remove passthrough account from Deposit and Withdraw insurance (+client)

Screenshot 2022-03-24 at 16 50 08

  • Refactor the app to remove any occurrences of passthrough account and simplify the quote/insurance mint difference to remove the migration (as it's kind of useless without the passthrough)

Screenshot 2022-03-24 at 18 42 22

@acamill acamill self-assigned this Mar 24, 2022
@acamill acamill added the enhancement New feature or request label Mar 24, 2022
@acamill acamill added this to the Soteria Audit milestone Mar 24, 2022
acamill added 2 commits March 24, 2022 18:44
- remove all passthrough
- merge insurance and quote mint, to prevent migration
- free up some space in the onchain accounts
- remove migrate instruction
@acamill acamill changed the base branch from main to acam/soteria-audit March 24, 2022 10:52
This was referenced Mar 24, 2022
@acamill
Copy link
Member Author

acamill commented Mar 25, 2022

I'm merging these branch into #137 so that I can do the whole testing. Please feel free to review and comment on these PR still @soteria-bc , will be easier. Will fix anything that come up

@acamill acamill merged commit c11f346 into acam/soteria-audit Mar 25, 2022
acamill added a commit that referenced this pull request Mar 29, 2022
* More liberal with the Solana program version to compat with Mango/Switchboard
Use latest mango

* Validate `perp_market` account where it's used. (#134)

* Add perp_market account check during validation step. We want to

* == insteadf of != for the `validate_perp_market_mint_matches_depository_collateral_mint`

* Update changelog

* [I-1] Remove passthrough usage from Mint instruction (#135)

* Remove passthrough usage from Mint instruction

* Remove the passthrough account in redeem

* Remove passthrough accounts from rebalance instruction

* Remove passthrough accounts from insurance withdraw/deposit

* Refactor
- remove all passthrough
- merge insurance and quote mint, to prevent migration
- free up some space in the onchain accounts
- remove migrate instruction

* Update client

* Prevent the corner case where the collateral_amount is below the contract_size (#136)

* Enable CI for audit branch

* - git ignore
- cargo fmt
- json idl
- tests

* Remove DEPOSITORY_VERSION check as the migration is no more. Update program devnet

* Remove depository cap change in test as it mess with concurency. Disregard test failing, next branch 3.1.0 has fully reworked test E2E. I'll merge these changes now and tests there.
@acamill acamill deleted the acam/audit-I1-redundant-passthrough-accounts branch April 21, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants