Soteria Audit re review (v3.0.2) #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tchboard Use latest mango
* Add perp_market account check during validation step. We want to * == insteadf of != for the `validate_perp_market_mint_matches_depository_collateral_mint` * Update changelog
* Remove passthrough usage from Mint instruction * Remove the passthrough account in redeem * Remove passthrough accounts from rebalance instruction * Remove passthrough accounts from insurance withdraw/deposit * Refactor - remove all passthrough - merge insurance and quote mint, to prevent migration - free up some space in the onchain accounts - remove migrate instruction * Update client
- cargo fmt - json idl - tests
Member
Author
|
Sol test suite Soteria Premium auto audit report : (30 unchecked accounts) Specifically rebalancing : Tested to deploy the current version (v2.4.0) and then upgrade to this program and monitor for issues :
State after program upgrade and test running (Insurance amount deposited is high cause I interrupted the deposit/withdraw test in between. All test passing. All good on my end 👍 waiting for your feedback guys, let's talk during tomorrow call |
…egard test failing, next branch 3.1.0 has fully reworked test E2E. I'll merge these changes now and tests there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perp_marketaccount where it's used. #134 C-1Merged branches to start the global testing, please feel free to audit separately and comment on each PR although it's closed
Misc :