Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Hooks: Type package#26430

Merged
sirreal merged 8 commits into
masterfrom
update/type-hooks
Nov 3, 2020
Merged

Hooks: Type package#26430
sirreal merged 8 commits into
masterfrom
update/type-hooks

Conversation

@sirreal

@sirreal sirreal commented Oct 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Type the Hooks package and include TypeScript type declarations in the published package.

Part of #18838

How has this been tested?

Tests pass and types are generated without issue.

Types of changes

New feature: Publish type declarations for the Hooks package.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@sirreal sirreal added [Type] Code Quality Issues or PRs that relate to code quality npm Packages Related to npm packages [Package] Hooks /packages/hooks labels Oct 23, 2020
@sirreal sirreal self-assigned this Oct 23, 2020
@sirreal sirreal mentioned this pull request Oct 23, 2020
Merged
6 tasks
@github-actions

github-actions Bot commented Oct 23, 2020 •
edited
Loading

Copy link
Copy Markdown

Size Change: +658 B (0%)

Total Size: 1.21 MB

Filename Size Change
build/block-library/editor-rtl.css 9.02 kB +49 B (0%)
build/block-library/editor.css 9.02 kB +48 B (0%)
build/block-library/index.js 146 kB +55 B (0%)
build/block-library/style-rtl.css 7.84 kB -15 B (0%)
build/block-library/style.css 7.85 kB -13 B (0%)
build/core-data/index.js 12.5 kB +216 B (1%)
build/edit-site/index.js 22.4 kB +290 B (1%)
build/edit-widgets/index.js 26.4 kB -1 B
build/hooks/index.js 2.16 kB +29 B (1%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.78 kB 0 B
build/api-fetch/index.js 3.45 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/theme-rtl.css 837 B 0 B
build/block-library/theme.css 838 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 172 kB 0 B
build/components/style-rtl.css 15.2 kB 0 B
build/components/style.css 15.2 kB 0 B
build/compose/index.js 9.81 kB 0 B
build/data-controls/index.js 772 B 0 B
build/data/index.js 8.77 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.46 kB 0 B
build/edit-navigation/index.js 11.2 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.41 kB 0 B
build/edit-post/style.css 6.39 kB 0 B
build/edit-site/style-rtl.css 3.88 kB 0 B
build/edit-site/style.css 3.88 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 43.1 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 7.7 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.11 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.34 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/rich-text/index.js 13.2 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@sirreal sirreal force-pushed the update/type-hooks branch 4 times, most recently from 11fecfa to 4a0edc7 Compare October 30, 2020 10:37
@sirreal sirreal marked this pull request as ready for review October 30, 2020 22:34
@sirreal

sirreal commented Oct 30, 2020

Copy link
Copy Markdown
Member Author

I'll fill in a description next week, I was excited the tests are passing because they've been unreliable 😅

@sirreal sirreal mentioned this pull request Oct 31, 2020
Closed
75 tasks
sirreal
sirreal commented Nov 2, 2020
View reviewed changes
Comment thread packages/hooks/tsconfig.json Outdated
sarayourfriend
sarayourfriend reviewed Nov 3, 2020
View reviewed changes
Comment thread packages/hooks/src/createAddHook.js
Comment thread packages/hooks/src/createRemoveHook.js
@sirreal sirreal merged commit 26806cb into master Nov 3, 2020
@sirreal sirreal deleted the update/type-hooks branch November 3, 2020 16:26
@github-actions github-actions Bot added this to the Gutenberg 9.4 milestone Nov 3, 2020
@jsnajdr jsnajdr mentioned this pull request Nov 12, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarayourfriend sarayourfriend sarayourfriend approved these changes
@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein
@gziolo gziolo Awaiting requested review from gziolo
@ajitbohra ajitbohra Awaiting requested review from ajitbohra
@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten
@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@sirreal sirreal

Labels

npm Packages Related to npm packages [Package] Hooks /packages/hooks [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 9.4

Development

Successfully merging this pull request may close these issues.

2 participants

@sirreal @sarayourfriend