-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #329 +/- ##
=======================================
Coverage 79.19% 79.19%
=======================================
Files 45 45
Lines 1817 1817
Branches 304 304
=======================================
Hits 1439 1439
Misses 377 377
Partials 1 1 Continue to review full report at Codecov.
|
8f56406
to
e101af5
Compare
Edit: empty package doesn't do anything. Users still need to perform |
e101af5
to
c14bd74
Compare
c14bd74
to
c4c83ed
Compare
@@ -326,7 +326,6 @@ these are links to the respective `README` documents. | |||
- [`crypto`](./packages/zilliqa-js-crypto/README.md) | |||
- [`proto`](./packages/zilliqa-js-proto/README.md) | |||
- [`util`](./packages/zilliqa-js-util/README.md) | |||
- [`viewblock`](https://github.com/Ashlar/zilliqa-js-viewblock/blob/master/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let add a note to inform the user that there exists Viewblock js lib and it can be assess over at https://github.com/Ashlar/zilliqa-js-viewblock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
4eeee79
to
685c8f2
Compare
Description
This PR removes the empty viewblock package. In this way, we can reduce complexity for test and bundling config.
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: