Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

feat: remove viewblock package #329

Merged
merged 2 commits into from
Aug 12, 2021
Merged

feat: remove viewblock package #329

merged 2 commits into from
Aug 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2021

Description

This PR removes the empty viewblock package. In this way, we can reduce complexity for test and bundling config.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #329 (6dce0c8) into dev (6add1ea) will not change coverage.
The diff coverage is n/a.

❗ Current head 6dce0c8 differs from pull request most recent head 685c8f2. Consider uploading reports for the commit 685c8f2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #329   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files          45       45           
  Lines        1817     1817           
  Branches      304      304           
=======================================
  Hits         1439     1439           
  Misses        377      377           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6add1ea...685c8f2. Read the comment docs.

@ghost ghost force-pushed the feat/remove-viewblock-package branch from 8f56406 to e101af5 Compare August 10, 2021 02:38
@teye
Copy link
Contributor

teye commented Aug 10, 2021

This seems like a breaking change by removing the zilliqa-js/viewblock package from the library? The package @zilliqa-js/viewblock is developed by Viewblock to allow developers to access viewblock API via Zilliqa-JS SDK.

If we planned to remove the package, I think we can update our main readme to ask users to run yarn add @zilliqa-js/viewblock as per https://www.npmjs.com/package/@zilliqa-js/viewblock if they need to access viewblock?

Edit: empty package doesn't do anything. Users still need to perform yarn add @zilliqa-js/viewblock if they need to access viewblock api. Safe to remove unless empty package is used to raise awareness of viewblock API?

@ghost ghost force-pushed the feat/remove-viewblock-package branch from e101af5 to c14bd74 Compare August 10, 2021 07:04
@charliecys charliecys closed this Aug 11, 2021
@charliecys charliecys reopened this Aug 11, 2021
@ghost ghost closed this Aug 11, 2021
@ghost ghost reopened this Aug 11, 2021
@ghost ghost force-pushed the feat/remove-viewblock-package branch from c14bd74 to c4c83ed Compare August 11, 2021 05:48
@@ -326,7 +326,6 @@ these are links to the respective `README` documents.
- [`crypto`](./packages/zilliqa-js-crypto/README.md)
- [`proto`](./packages/zilliqa-js-proto/README.md)
- [`util`](./packages/zilliqa-js-util/README.md)
- [`viewblock`](https://github.com/Ashlar/zilliqa-js-viewblock/blob/master/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let add a note to inform the user that there exists Viewblock js lib and it can be assess over at https://github.com/Ashlar/zilliqa-js-viewblock

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@ghost ghost force-pushed the feat/remove-viewblock-package branch from 4eeee79 to 685c8f2 Compare August 12, 2021 06:51
@bb111189 bb111189 merged commit 5a026ef into dev Aug 12, 2021
@ghost ghost deleted the feat/remove-viewblock-package branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants