Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add notice annotation and support more annotation fields #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 28, 2021
Merged

Add notice annotation and support more annotation fields #855

merged 9 commits into from
Jul 28, 2021

Conversation

luketomlinson
Copy link
Contributor

@luketomlinson luketomlinson commented Jun 29, 2021 •
edited
Loading

This PR adds support for:

  • The notice annotation level.
  • The title, line, endLine, col, and endColumn fields.

Depends on these runner changes.

@luketomlinson luketomlinson requested a review from a team as a code owner June 29, 2021 18:35
luketomlinson
luketomlinson commented Jun 29, 2021
View reviewed changes
thboop
thboop reviewed Jun 30, 2021
View reviewed changes
thboop
thboop reviewed Jun 30, 2021
View reviewed changes
thboop
thboop reviewed Jun 30, 2021
View reviewed changes
thboop
thboop reviewed Jun 30, 2021
View reviewed changes
thboop
thboop reviewed Jun 30, 2021
View reviewed changes
@luketomlinson luketomlinson force-pushed the annotations-updates branch from e05b631 to a5df6ef Compare July 2, 2021 19:03
thboop
thboop approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ericsciple
ericsciple reviewed Jul 13, 2021
View reviewed changes
thboop
thboop reviewed Jul 13, 2021
View reviewed changes
ericsciple
ericsciple reviewed Jul 13, 2021
View reviewed changes
ericsciple
ericsciple reviewed Jul 13, 2021
View reviewed changes
@luketomlinson luketomlinson merged commit f0b00fd into main Jul 28, 2021
@luketomlinson luketomlinson deleted the annotations-updates branch July 28, 2021 21:34
@vitaliimelnychuk vitaliimelnychuk mentioned this pull request Aug 24, 2021
Open
@warnyul warnyul mentioned this pull request Jan 30, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thboop thboop thboop approved these changes

@ericsciple ericsciple ericsciple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luketomlinson @ericsciple @thboop