fixing docs badge, adding link to guide, and removing redundant kwargs #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
suggested changes
Dec 6, 2018
README.rst
Outdated
| @@ -54,7 +54,9 @@ To install in a virtual environment in your current project: | |||
| Usage Example | |||
| ============= | |||
|
|
|||
| Usage example is described in the learn guide for this library. | |||
| Usage is described in the `learn guide for this library<https://learn.adafruit.com/using-lorawan-and-the-things-network-with-circuitpython>`_. | |||
There was a problem hiding this comment.
I think you're missing a space after library.
README.rst
Outdated
| .. image:: https://readthedocs.org/projects/adafruit-circuitpython-tinylora/badge/?version=latest | ||
| :target: https://circuitpython.readthedocs.io/projects/tinylora/en/latest/ | ||
| .. image:: https://readthedocs.org/projects/circuitpython-tinylora/badge/?version=latest | ||
| :target: https://circuitpython-tinylora.readthedocs.io/en/latest/ |
There was a problem hiding this comment.
Why did you change this? If the URL provided by cookiecutter isn't working it means there's an issue on the RTD end that needs to be addressed. TinyLoRa documentation doesn't appear to have been setup properly in RTD. Please ping me for the proper process for this.
kattni
approved these changes
Dec 6, 2018
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 20, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#12 from brentru/fix-freq-comments > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#11 from brentru/example-spi-ordering > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#10 from philwilkinson40/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#6 from brentru/readme-modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with the Readme RTD badge not pointing correctly.
Add link to guide (publishing soon) to README.
Remove redundant kwargs from spi object init.