Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[strings] fix example #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[strings] fix example #261

wants to merge 1 commit into from

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Mar 27, 2015

Fixes:

The "bad" and "good" examples on using arrays to build long strings are not equivalent. If the array is empty, the "bad" code will return <ul></ul> and the "good" code will return <ul><li></li></ul>

http://www.reddit.com/r/javascript/comments/30hyan/airbnb_javascript_style_guide_a_mostly_reasonable/cpsngtz

Thanks Reddit 🍻

@goatslacker

@goatslacker
Copy link
Collaborator

There's also this PR: #260

@hshoff
Copy link
Member Author

hshoff commented Mar 27, 2015

doh.

@hshoff hshoff closed this Mar 27, 2015
@hshoff hshoff deleted the hshoff/fix-strings-example branch March 27, 2015 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hshoff @goatslacker