fix(ngcc): re-enable killing ngcc (and CLI) via Ctrl-C #35861
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ae0fad to
e8936a3
Compare
The previous implementation mixed up the management of locking a piece of code (both sync and async) with the management of writing and removing the lockFile that is used as the flag for which process has locked the code. This change splits these two concepts up. Apart from avoiding the awkward base class it allows the `LockFile` implementation to be replaced cleanly.
e8936a3 to
6f26443
Compare
gkalpak
requested changes
Mar 5, 2020
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/util.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/util.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/index.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/index.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/index.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/unlocker.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/test/locking/lockfile_with_child_process/unlocker_spec.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/unlocker.ts
Show resolved
Hide resolved
JoostK
reviewed
Mar 5, 2020
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/index.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/src/locking/lock_file_with_child_process/index.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/ngcc/test/locking/lockfile_with_child_process/index_spec.ts
Outdated
Show resolved
Hide resolved
This version of `LockFile` creates an "unlocker" child-process that monitors the main ngcc process and deletes the lock file if it exits unexpectedly. This resolves the issue where the main process could not be killed by pressing Ctrl-C at the terminal. Fixes angular#35761
12f50c1 to
2ba269f
Compare
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
14dad68 to
e5f5883
Compare
JoostK
approved these changes
Mar 5, 2020
|
@petebacondarwin please rebase and make this work with the |
matsko
pushed a commit
that referenced
this pull request
Mar 5, 2020
The previous implementation mixed up the management of locking a piece of code (both sync and async) with the management of writing and removing the lockFile that is used as the flag for which process has locked the code. This change splits these two concepts up. Apart from avoiding the awkward base class it allows the `LockFile` implementation to be replaced cleanly. PR Close #35861
matsko
pushed a commit
that referenced
this pull request
Mar 5, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35761
For the moment I have left the old implementation in there too. We should probably remove it either as part of this PR or soonish, unless we decide that we want to make it configurable and allow people the different options.