Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat!: angular-eslint v20 #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat!: angular-eslint v20 #2448

wants to merge 10 commits into from
+1,509 −517

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented May 24, 2025 •
edited
Loading

The contents of this branch are already available to use under the prerelease-v20 dist tag on npm:

https://www.npmjs.com/package/angular-eslint/v/prerelease-v20

Final Items before 20.0.0:

  • Required: Double check remaining recommended rules do not contravene the rewritten Angular style guide
  • Nice to have: Fix up style guide links and description to match the rewritten Angular style guide (will otherwise come in patch releases on 20.x.x)

## TODOs Completed Items

Fixes #2206
FIxes #2481

@JamesHenry JamesHenry added this to the v20 milestone May 24, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4de9342.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 11m 44s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 24s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 35s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 3s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗
nx run-many -t test ✅ Succeeded 14s View ↗
nx run-many -t build ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-06 13:18:24 UTC

@JamesHenry
Copy link
Member Author

JamesHenry commented May 24, 2025 •
edited
Loading

@reduckted Please see 51691cf an existing test case of yours causes a parse error now after your PR to switch them on by default

@JamesHenry JamesHenry added the BREAKING CHANGE This is a breaking change and should only be released as part of a new major version label May 24, 2025
@codecov Codecov
Copy link

codecov bot commented May 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.82828% with 17 lines in your changes missing coverage. Please review.

Project coverage is 92.62%. Comparing base (3037d4a) to head (4de9342).

Files with missing lines Patch % Lines
...ugin-template/src/rules/prefer-template-literal.ts 75.55% 10 Missing and 1 partial ⚠️
...plate/src/rules/prefer-contextual-for-variables.ts 81.25% 1 Missing and 2 partials ⚠️
...tics/src/migrations/update-20-0-0/update-20-0-0.ts 81.81% 1 Missing and 1 partial ⚠️
...lint-plugin-template/src/rules/no-negated-async.ts 83.33% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (82.82%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2448      +/-   ##
==========================================
- Coverage   92.88%   92.62%   -0.27%     
==========================================
  Files         200      202       +2     
  Lines        4232     4272      +40     
  Branches      996     1002       +6     
==========================================
+ Hits         3931     3957      +26     
- Misses        232      245      +13     
- Partials       69       70       +1
Flag Coverage Δ
unittest 92.62% <82.82%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin-template/src/rules/conditional-complexity.ts 100.00% <100.00%> (ø)
...plate/src/utils/unwrap-parenthesized-expression.ts 100.00% <100.00%> (ø)
...eslint-plugin-template/tests/rules/eqeqeq/cases.ts 100.00% <ø> (ø)
...s/eslint-plugin-template/tests/rules/i18n/cases.ts 100.00% <ø> (ø)
...n-template/tests/rules/no-call-expression/cases.ts 100.00% <ø> (ø)
...-plugin-template/tests/rules/prefer-ngsrc/cases.ts 100.00% <ø> (ø)
...plate/tests/rules/prefer-template-literal/cases.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/component-class-suffix.ts 91.66% <ø> (-0.65%) ⬇️
.../eslint-plugin/src/rules/directive-class-suffix.ts 95.23% <ø> (-0.22%) ⬇️
packages/eslint-plugin/src/rules/prefer-inject.ts 78.12% <ø> (ø)
... and 9 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@reduckted reduckted mentioned this pull request May 25, 2025
Merged
@reduckted
Copy link
Contributor

@reduckted Please see 51691cf an existing test case of yours causes a parse error now after your PR to switch them on by default

Fixed in #2450.

@JamesHenry JamesHenry reopened this May 25, 2025
@JamesHenry JamesHenry force-pushed the next-major-release/v20 branch 4 times, most recently from 19311a3 to cbd76c4 Compare May 27, 2025 14:19
@angular-eslint angular-eslint deleted a comment from claude bot May 27, 2025
@angular-eslint angular-eslint deleted a comment from claude bot May 27, 2025
@JamesHenry JamesHenry force-pushed the next-major-release/v20 branch 2 times, most recently from d29cd95 to c495e5d Compare May 28, 2025 18:08
@leosvelperez leosvelperez mentioned this pull request May 29, 2025
Open
18 tasks
@JamesHenry JamesHenry force-pushed the next-major-release/v20 branch 2 times, most recently from 1fd2730 to 17c56ad Compare June 1, 2025 07:44
@andgdk andgdk mentioned this pull request Jun 1, 2025
Draft
18 tasks
@JamesHenry JamesHenry force-pushed the next-major-release/v20 branch 2 times, most recently from 20fd42c to cc39c58 Compare June 2, 2025 10:34
@JamesHenry JamesHenry marked this pull request as ready for review June 2, 2025 11:08
@JamesHenry JamesHenry force-pushed the next-major-release/v20 branch from cc39c58 to 15748a7 Compare June 6, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BREAKING CHANGE This is a breaking change and should only be released as part of a new major version
Projects
None yet
Milestone
v20
Development

Successfully merging this pull request may close these issues.

[sort-keys-in-type-decorator] should include "host" [@angular-eslint/prefer-standalone] The rule prefer-standalone should not be "fixable"
2 participants
@JamesHenry @reduckted