-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add an option to disable middle click to paste on Linux #3904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abdnh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is maybe better added to the Rust backend (See the paste_strips_formatting implementation for reference)
It's PyQt that intercepts the mouse event and then immediately calls QWebEnginePage.WebAction.Paste; I don't see how or why it should be part of the backend |
|
I only mean the storage part (being stored in the collection config like other pasting options) |
Ah, yeah I was unsure where to store the setting, in this PR it's in the profile but here it's in the collection (tho I now have to fix a few things in that branch) |
|
@abdnh ok, I've fixed what needed to be fixed in the other branch and tested the change (unless there's something else I missed); but now I'm unsure what to do with the PR. |
0a184be to
0aa4012
Compare
|
@dae one last thing I'm unsure about, is that in the example you provided, browserTableTooltips wasn't added to profileConf, and I don't understand what the criteria for that is and if I should remove what I added in that dict |
|
I've added a comment to make it clearer in the future. Thank you! |
|
I see it now |
|
All good! |
Add an option to disable middle click to paste on Linux as a boolean in profileConf
I made sure to test if the setting works and saves properly, and can also confirm it won't cause issues when downgrading