Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@derivativeoflog7
Copy link
Contributor

@derivativeoflog7 derivativeoflog7 commented Apr 7, 2025

Add an option to disable middle click to paste on Linux as a boolean in profileConf
I made sure to test if the setting works and saves properly, and can also confirm it won't cause issues when downgrading

Copy link
Collaborator

@abdnh abdnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe better added to the Rust backend (See the paste_strips_formatting implementation for reference)

@derivativeoflog7
Copy link
Contributor Author

derivativeoflog7 commented Apr 8, 2025

This is maybe better added to the Rust backend (See the paste_strips_formatting implementation for reference)

It's PyQt that intercepts the mouse event and then immediately calls QWebEnginePage.WebAction.Paste; I don't see how or why it should be part of the backend

@abdnh
Copy link
Collaborator

abdnh commented Apr 8, 2025

I only mean the storage part (being stored in the collection config like other pasting options)

@derivativeoflog7
Copy link
Contributor Author

I only mean the storage part (being stored in the collection config like other pasting options)

Ah, yeah I was unsure where to store the setting, in this PR it's in the profile but here it's in the collection (tho I now have to fix a few things in that branch)

@derivativeoflog7
Copy link
Contributor Author

derivativeoflog7 commented Apr 8, 2025

@abdnh ok, I've fixed what needed to be fixed in the other branch and tested the change (unless there's something else I missed); but now I'm unsure what to do with the PR.
I'll also use this chance to say that the remaining failing test seems to be from an issue outside of my control (and is failing for other PRs too)

@abdnh
Copy link
Collaborator

abdnh commented Apr 8, 2025

You can close this PR and open a new one.

I'll also use this chance to say that the remaining failing test seems to be from an issue outside of my control (and is failing for other PRs too)

Yes. We need to wait for @dae to merge #3906 to fix the tests.

@derivativeoflog7
Copy link
Contributor Author

#3908

@derivativeoflog7
Copy link
Contributor Author

derivativeoflog7 commented Apr 13, 2025

@dae one last thing I'm unsure about, is that in the example you provided, browserTableTooltips wasn't added to profileConf, and I don't understand what the criteria for that is and if I should remove what I added in that dict

@dae
Copy link
Member

dae commented Apr 15, 2025

I've added a comment to make it clearer in the future. Thank you!

@dae dae merged commit 369dec9 into ankitects:main Apr 15, 2025
1 check passed
@derivativeoflog7
Copy link
Contributor Author

I see it now
Also sorry for the FTL stuff

@dae
Copy link
Member

dae commented Apr 15, 2025

All good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants