Fix mirror configuration not working during launcher download #4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for looking into this. Unfortunately, there's a conflict on the CONTRIBUTORS file. Could I trouble you to rebase over the latest main, so I can merge this in? |
Use environment variable instead of configuration file
Contributor
Author
Rebased onto the latest main and resolved the CONTRIBUTORS conflict. Thanks! |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m the author of the post referenced in #4226. Thanks for noticing and addressing this issue.
However, the current fix doesn’t work on my side, likely because:
uv syncanki/qt/launcher/src/main.rs
Line 301 in 68bc4c0
uv run versions.pyanki/qt/launcher/src/main.rs
Line 663 in 68bc4c0
--no-config, so the mirror settings in the config file are ignored (main cause).uv run versions.pydownloads the Python interpreter before the mirror settings have been written to the config file.Using environment variables to configure the mirror would work better in this flow. I’ve tested this locally and can confirm it resolves the issue for me.