-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Decode images asynchronously #4320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Interestingly, there are some reports that it can actually slow down the loading of large images: No personal experience with this, and no strong feelings. If you'd like to merge this so we can get feedback from beta testers, please feel free. |
|
Sigh - I'd planned to update the custom color PR to use the collection prior to building the release, but managed to forget about it, so I'll need to build .2 now. Just wanted to check your intentions here: I presume you wanted this to be merged after the patch release, not before it? |
Oh, I didn't notice you made a release actually. I wanted to merge it before that. |
|
Ok 👍 |
|
It seems to perform slightly worse on my computer (Windows 11) when there are multiple images: Anki 25.09rc1: 25.09rc1.mp4Anki 25.09.2: 25.09.2.mp4 |
|
@jcznk Did you notice any rendering speed improvements as you flip through cards with images? |
|
@abdnh Yes, the cards do seem to load a bit faster, especially when they contain large pictures. But the images themselves often lag, and the overall effect is somewhat "flickery". |
|
Hello, I think this change is causing massive image flickering on cards that utilize CT/MRI scrolling. |
|
I've created #4373 |
|
I have noticed that images tend to load slower on cards that have a large number of images, but faster when there are only 1 or 2 images. |
The images take too much time to load now on the new version |
This sets the
decodingproperty forimgelements toasyncto avoid blocking rendering of card content while images are being loaded, which is a common issue with notes with a lot of images or high resolutions. I found setting this noticeably reduces lag.