Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: bump google-closure-compiler from 20240317.0.0 to 20250603.0.0#149

Merged
kou merged 2 commits intomainfrom
dependabot/npm_and_yarn/google-closure-compiler-20250603.0.0
Jun 12, 2025
Merged

chore: bump google-closure-compiler from 20240317.0.0 to 20250603.0.0#149
kou merged 2 commits intomainfrom
dependabot/npm_and_yarn/google-closure-compiler-20250603.0.0

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 9, 2025

Bumps google-closure-compiler from 20240317.0.0 to 20250603.0.0.

Release notes

Sourced from google-closure-compiler's releases.

20250603.0.0

Closure-compiler 20250603 release

What's Changed

Full Changelog: google/closure-compiler-npm@v20250601.0.0...v20250603.0.0

20250601.0.0

Closure-compiler 20250601 release

What's Changed

Full Changelog: google/closure-compiler-npm@v20250528.0.0...v20250601.0.0

20250528.0.0

Closure-compiler 20250528 release

What's Changed

Full Changelog: google/closure-compiler-npm@v20250526.0.0...v20250528.0.0

20250526.0.0

Closure-compiler 20250526 release

Full Changelog: google/closure-compiler-npm@v20250520.0.0...v20250526.0.0

20250520.0.0

Closure-compiler 20250520 release

Full Changelog: google/closure-compiler-npm@v20250519.0.0...v20250520.0.0

20250519.0.0

Closure-compiler 20250519 release

What's Changed

Full Changelog: google/closure-compiler-npm@v20250518.0.0...v20250519.0.0

20250518.0.0

Closure-compiler 20250518 release

What's Changed

... (truncated)

Commits
  • d35d0c7 v20250603.0.0
  • 267cc25 [skip ci] Allow the release workflow to mutate the yarn.lock file
  • 799cec3 [skip ci] Add stdio config so errors can be seen
  • 2c1a1e9 [skip ci] nit: minor optimization
  • 94446ff [skip ci] simpler iteration
  • 4c6a3bc [skip ci] Remove outdated comment on GLIBC compatibility
  • 09e2be5 Update versioning scripts for yarn 4
  • dfb04a4 Update the release workflow for modern yarn
  • 87f9b77 Remove custom registry setting
  • bc7a2fb Update the yarn.lock file
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [google-closure-compiler](https://github.com/google/closure-compiler-npm) from 20240317.0.0 to 20250603.0.0.
- [Release notes](https://github.com/google/closure-compiler-npm/releases)
- [Commits](google/closure-compiler-npm@v20240317.0.0...v20250603.0.0)

---
updated-dependencies:
- dependency-name: google-closure-compiler
  dependency-version: 20250603.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 9, 2025
@kou
Copy link
Member

kou commented Jun 10, 2025

@trxcllnt @domoritz Do we keep using google-closure-compiler? Can we remove it?

@trxcllnt
Copy link
Contributor

I thought we removed it, but I'll have to check

@trxcllnt
Copy link
Contributor

Oh yes, it looks like we still use it to compile the UMD bundles. We could try removing it in favor of webpack + terser, but I don't have the bandwidth for that at the moment.

@trxcllnt
Copy link
Contributor

trxcllnt commented Jun 10, 2025

The example in their docs shows gulp is now a named export, so we might just need to change these two lines to:

import { gulp as compiler } from 'google-closure-compiler';

@kou
Copy link
Member

kou commented Jun 12, 2025

Thanks! It worked! I'll merge this.

BTW, it seems that we can generate UMD module by tsc: https://www.typescriptlang.org/tsconfig/#umd

@kou kou merged commit 289d4b8 into main Jun 12, 2025
10 checks passed
@kou kou deleted the dependabot/npm_and_yarn/google-closure-compiler-20250603.0.0 branch June 12, 2025 06:58
@trxcllnt
Copy link
Contributor

That only creates the UMD wrapper, it doesn't transpile, optimize, and minify like closure-compiler does.

@kou
Copy link
Member

kou commented Jun 13, 2025

OK. (But I think that tsc does transpile (TypeScript -> JavaScript).)

Then we should keep using google-closure-compiler, right? If so, I'll close #153.

@trxcllnt
Copy link
Contributor

tsc transpiles from TS to JS, but closure-compiler downlevels ES2020 -> ES5 and optimizes along the way. We can still replace it with terser if we don't want to use it anymore, I was just commenting that tsc itself isn't a direct replacement.

@kou
Copy link
Member

kou commented Jun 13, 2025

Ah, I see. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants