Thanks to visit codestin.com
Credit goes to github.com

Skip to content

UI: Move templates creation date to the Zones tab #10709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

nvazquez
Copy link
Contributor

Description

This PR moves the creation date of a template to the Zones tab on the template view and removes the zone field on the left side menu. This behavior is changed to support templates on multiple zones, which should display the different creation dates for each zone. These are correctly displayed on the Template view -> Zones tab.

Screenshot 2025-04-14 at 11 00 55

Fixes: #10599

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (f13cf59) to head (d452375).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10709   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
- Complexity    11332    11333    +1     
=========================================
  Files          5415     5415           
  Lines        474893   474893           
  Branches      57920    57920           
=========================================
+ Hits          72046    72048    +2     
+ Misses       394792   394791    -1     
+ Partials       8055     8054    -1     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10709 (QA-JID-596)

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvazquez Could you please add the same behaviour of ISO and kubernets iso section also

Screenshot 2025-04-15 at 11 21 02 AM

@DaanHoogland
Copy link
Contributor

I agree with @kiranchavala on ISOs. I’m not so sure about k8s ISOs. Can you have a look @nvazquez ?

@nvazquez
Copy link
Contributor Author

@kiranchavala @DaanHoogland I have applied the changes for ISOs, however the Kubernetes ISOs view doesn't have the Zones section per se, have to then select the created ISO to view it

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10709 (QA-JID-598)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm (tested in qa)

@nvazquez nvazquez linked an issue Apr 15, 2025 that may be closed by this pull request
Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Tested in the qa server

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache merged commit 8db248e into apache:4.19 Apr 17, 2025
26 checks passed
@DaanHoogland DaanHoogland deleted the 419-templatezones-ui branch April 17, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI : Creation date of Template is changed when its copied
5 participants