-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Move templates creation date to the Zones tab #10709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10709 +/- ##
=========================================
Coverage 15.17% 15.17%
- Complexity 11332 11333 +1
=========================================
Files 5415 5415
Lines 474893 474893
Branches 57920 57920
=========================================
+ Hits 72046 72048 +2
+ Misses 394792 394791 -1
+ Partials 8055 8054 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nvazquez Could you please add the same behaviour of ISO and kubernets iso section also
I agree with @kiranchavala on ISOs. I’m not so sure about k8s ISOs. Can you have a look @nvazquez ? |
@kiranchavala @DaanHoogland I have applied the changes for ISOs, however the Kubernetes ISOs view doesn't have the Zones section per se, have to then select the created ISO to view it |
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ltgm (tested in qa)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Tested in the qa server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
Description
This PR moves the creation date of a template to the Zones tab on the template view and removes the zone field on the left side menu. This behavior is changed to support templates on multiple zones, which should display the different creation dates for each zone. These are correctly displayed on the Template view -> Zones tab.
Fixes: #10599
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?