Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix for Vlan doesn't match issue while adding IP range for the shared network without any IP range #10837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from
Open

Fix for Vlan doesn't match issue while adding IP range for the shared network without any IP range #10837

wants to merge 1 commit into from
+61 −39

Conversation

sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented May 8, 2025 •
edited
Loading

Description

This PR fixes Vlan doesn't match issue while adding IP range for the shared network without any IP range.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before Fix:

SharedNetwork_AddIpRange_VlanMismatchIssue

After Fix:

SharedNetwork_AddIpRange_AfterFix

How Has This Been Tested?

  • Create a shared network, delete the ip range and add new ip range.

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti force-pushed the shared-network-vlan-doesnt-match-issue-while-adding-ip-range branch from c67649a to 4efa3af Compare May 8, 2025 15:13
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 19.44444% with 29 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (f0838cd) to head (4efa3af).

Files with missing lines Patch % Lines
.../cloud/configuration/ConfigurationManagerImpl.java 19.44% 25 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10837   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
  Complexity    11339    11339           
=========================================
  Files          5414     5414           
  Lines        475185   475196   +11     
  Branches      57991    57993    +2     
=========================================
+ Hits          72105    72111    +6     
- Misses       395018   395019    +1     
- Partials       8062     8066    +4
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <19.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti sureshanaparti added this to the 4.19.3 milestone May 8, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13303

@sureshanaparti sureshanaparti marked this pull request as ready for review May 9, 2025 06:47
@sureshanaparti
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees
No one assigned
Labels
component:api status:needs-testing
Projects
None yet
Milestone
4.19.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sureshanaparti @blueorangutan