Fix for Vlan doesn't match issue while adding IP range for the shared network without any IP range #10837
Conversation
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
… network without any IP range
c67649a to
4efa3af
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10837 +/- ##
=========================================
Coverage 15.17% 15.17%
Complexity 11339 11339
=========================================
Files 5414 5414
Lines 475185 475196 +11
Branches 57991 57993 +2
=========================================
+ Hits 72105 72111 +6
- Misses 395018 395019 +1
- Partials 8062 8066 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13303 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
| vlanId = getNetworkVlanId(network, connectivityWithoutVlan); | ||
| } | ||
| } | ||
|
|
||
| // TODO decide if we should be forgiving or demand a valid and complete URI | ||
| if (!(vlanId == null || "".equals(vlanId) || vlanId.startsWith(BroadcastDomainType.Vlan.scheme()))) { | ||
| vlanId = BroadcastDomainType.Vlan.toUri(vlanId).toString(); | ||
| } | ||
| final Boolean forVirtualNetwork = cmd.isForVirtualNetwork(); |
There was a problem hiding this comment.
does this need to be cleaned up ?
Description
This PR fixes Vlan doesn't match issue while adding IP range for the shared network without any IP range.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before Fix:
After Fix:
How Has This Been Tested?
How did you try to break this feature and the system with this change?