Bump actions/setup-java from 5.4.0 to 5.5.0#12460
Conversation
setup-java v5.5.0 now sets MAVEN_ARGS=-ntp by default, which suppresses transfer progress output. This breaks 3 integration tests that verify transfer listener behavior (mng-4461, mng-4829, mng-6240). Add show-download-progress: true to the integration-test job so the ITs can still exercise Maven's transfer progress output. Co-Authored-By: Claude Opus 4.6 <[email protected]>
gnodet
left a comment
There was a problem hiding this comment.
Review — CI Version Bump
Clean version bump of actions/setup-java from v5.4.0 to v5.5.0 on the maven-3.10.x branch. Pinned commit hash correctly updated.
The show-download-progress: true addition on the integration-test job is well-motivated — v5.5.0 injects MAVEN_ARGS=-ntp by default, which would suppress transfer progress output and break three ITs that verify transfer listener behavior. Applying it only to the integration-test job while letting the build job keep the cleaner -ntp default is a sensible split. All 18 CI checks pass. ✅
No issues found. LGTM (own PR, can't APPROVE).
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
Reviewed apache#12459 and apache#12460 (actions/setup-java version bumps). Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
Closing in favor of pushing the fix directly to the Dependabot branch on #12439. |
Summary
actions/setup-javafrom 5.4.0 to 5.5.0show-download-progress: trueto the integration-test job to fix CI failuresContext
Supersedes #12439.
setup-javav5.5.0 (changelog) introduces a new default that setsMAVEN_ARGS=-ntp(--no-transfer-progress) to suppress Maven transfer/download progress output in CI logs (actions/setup-java#1053).Since
MAVEN_ARGSis honored by Maven 3.9.0+, this suppresses transfer progress output in the forked Maven processes spawned by the integration tests, breaking 3 ITs that verify transfer listener behavior:MavenITmng4829ChecksumFailureWarningTestMavenITmng4461ArtifactUploadMonitorTestMavenITmng6240PluginExtensionAetherProviderThe fix adds
show-download-progress: trueto thesetup-javastep in the integration-test job, which opts out of the new-ntpdefault. The build job keeps the default (cleaner logs).Test plan
🤖 Generated with Claude Code