Thanks to visit codestin.com
Credit goes to github.com

Skip to content

adapter: simplify compareByIdThenRev() #8787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alxndrsn merged 6 commits into from
Oct 14, 2023
Merged

adapter: simplify compareByIdThenRev() #8787

alxndrsn merged 6 commits into from
Oct 14, 2023

Conversation

@alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 12, 2023

Remove one layer of functions.

garethbowen
garethbowen reviewed Oct 12, 2023
View reviewed changes
garethbowen
garethbowen reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this function used a lot? Does this yield a measurable improvement?

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Oct 12, 2023

Is this function used a lot? Does this yield a measurable improvement?

I suspect not - it's specific to bulkDocs(..., { ..., new_edits: true, ...})

@SourceR85
Copy link
Contributor

SourceR85 commented Oct 12, 2023 •
edited
Loading

Is this function used a lot? Does this yield a measurable improvement?

I suspect not - it's specific to bulkDocs(..., { ..., new_edits: true, ...})

bulkDocs get called by every api-call to PouchDB.post... true is the default value for new_edits in this case.
I think the relative performance impact depends on the use case.

Edit: PouchDB.put omits the use of bulkDocs, if new_edits is set to true or a specialized _put function is available (adapter http).

garethbowen
garethbowen approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little on the fence here... I think it's a little less readable, but should be a little faster. But I'm not one to stand in the way of progress, so approved!

@alxndrsn alxndrsn merged commit 9f01e63 into apache:master Oct 14, 2023
@alxndrsn alxndrsn deleted the newedits-false-revs-over-10 branch October 14, 2023 15:32
alxndrsn added a commit to alxndrsn/pouchdb that referenced this pull request Nov 6, 2023
@alxndrsn
adapter: simplify compareByIdThenRev() (apache#8787)
38b5dcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garethbowen garethbowen garethbowen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alxndrsn @SourceR85 @garethbowen