Thanks to visit codestin.com
Credit goes to github.com

Skip to content

adapter: simplify compareByIdThenRev() #8787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxndrsn merged 6 commits into from
Oct 14, 2023
Merged

adapter: simplify compareByIdThenRev() #8787

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f909e45
try new test
Oct 12, 2023
7ad2d7a
revert tests
Oct 12, 2023
81daaf7
eliminate compare fn
Oct 12, 2023
98a8522
fix indentation
Oct 12, 2023
b525452
Merge remote-tracking branch 'upstream/master' into newedits-false-re…
Oct 12, 2023
702d653
Merge branch 'master' into newedits-false-revs-over-10
alxndrsn Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions packages/node_modules/pouchdb-core/src/adapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ import {
* A generic pouch adapter
*/

function compare(left, right) {
return left < right ? -1 : left > right ? 1 : 0;
}

// Wrapper for functions that call the bulkdocs api with a single doc,
// if the first result is an error, return an error
function yankError(callback, docId) {
Expand Down Expand Up @@ -78,13 +74,12 @@ function cleanDocs(docs) {

// compare two docs, first by _id then by _rev
function compareByIdThenRev(a, b) {
var idCompare = compare(a._id, b._id);
if (idCompare !== 0) {
return idCompare;
if (a._id === b._id) {
const aStart = a._revisions ? a._revisions.start : 0;
const bStart = b._revisions ? b._revisions.start : 0;
return aStart - bStart;
}
var aStart = a._revisions ? a._revisions.start : 0;
var bStart = b._revisions ? b._revisions.start : 0;
return compare(aStart, bStart);
return a._id < b._id ? -1 : 1;
}

// for every node in a revision tree computes its distance from the closest
Expand Down